Conversation
amardanov
reviewed
Feb 7, 2024
| // MARK: - UICollectionViewDataSource | ||
|
|
||
| extension StatisticsViewController: UICollectionViewDelegate { | ||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize { |
There was a problem hiding this comment.
Рекомендую придерживаться следующего стиля написания длинных вызовов и длинных объявлений функций.
func collectionView(
_ collectionView: UICollectionView,
layout collectionViewLayout: UICollectionViewLayout,
sizeForItemAt indexPath: IndexPath
) -> CGSize {
Такой формат принят за основу во многих компаниях и следование ему даст несколько очков к карме при работе над боевыми проектами
amardanov
reviewed
Feb 7, 2024
| statistics.removeAll() | ||
| } else { | ||
| statistics = [ | ||
| .init(title: "Лучший период", value: "\(bestPeriod())"), |
There was a problem hiding this comment.
Рекомендую НЕ использовать .init для создания объектов, так как такой способ работает чуть медленнее, а если таких месть будет больше, то разница будет ощутимой. Лучше использовать полное название класса/структуры для инициализаци. Например тут будет:
StatisticsModel(title: "Лучший период", value: "\(bestPeriod())")
amardanov
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Так как это тоже сервис, то лучше перенести всю папку в папку Services, а AppDelegate и SceneDelegate наоборот оттуда убрать
amardanov
reviewed
Feb 7, 2024
added 2 commits
February 11, 2024 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.