Skip to content

fix: social icons visibility in light and dark theme#63

Open
AribaRazi wants to merge 1 commit into
revatikadam0607:mainfrom
AribaRazi:fix/social-icons
Open

fix: social icons visibility in light and dark theme#63
AribaRazi wants to merge 1 commit into
revatikadam0607:mainfrom
AribaRazi:fix/social-icons

Conversation

@AribaRazi

Copy link
Copy Markdown

Fixed issue #54

Overview

This PR improves the visibility and consistency of the social media icons displayed in the hero section by fixing GitHub icon rendering issues and increasing the overall icon size for better visual balance.

Changes Made

GitHub Icon Fix

Added explicit inline dimensions to the GitHub icon <img> element to ensure consistent rendering across different browsers and devices.

Added:

  • width="28"
  • height="28"

Social Icon Size Update

Updated the .hero-social img dimensions in css/components.css from 20px to 25px to improve visibility and alignment within the circular icon containers.
css:-
.hero-social img {
width: 25px;
height: 25px;
}

Files Changed

index.html
Added inline width and height styling to the GitHub icon

css/components.css
Updated .hero-social img size from 20px to 25px

BEFORE

In light mode-

Screenshot 2026-05-16 173325 ### In dark mode- Screenshot 2026-05-16 173355

AFTER

In light mode-

image ### In Dark mode- image

Reason for Change

  • Ensures consistent GitHub icon rendering across browsers
  • Improves icon visibility and overall UI balance
  • Enhances appearance without affecting existing functionality

Note:- This is a UI-only update with no functional impact.

@AribaRazi

Copy link
Copy Markdown
Author

hello @revatikadam0607 plz review this PR

@revatikadam0607 revatikadam0607 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hey, thanks for the PR!
I noticed it’s causing some UI issues in the Skills section — the layout/cards got misaligned after the changes. Could you please check the recent commits and fix the styling once? 🙌

@AribaRazi

Copy link
Copy Markdown
Author

hello @revatikadam0607
image
Actually when i am running it locally the skills section is aligned properly

@revatikadam0607

Copy link
Copy Markdown
Owner

Actually when i am running it locally the skills section is aligned properly

Thanks for checking it locally
However, on my side the Skills section still doesn’t seem to be aligned properly. Could you please recheck it once again across different screen sizes/devices and make sure the alignment issue is fully resolved?
Once it looks consistent, I’ll review it again. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants