added dynamic time-based greeting#61
Open
adityakhati-03 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE - #56
This PR enhances the landing page greeting by making it dynamic and increasing its visibility. Instead of a static "HELLO!", the portfolio now greets visitors based on their current local time.
Changes Made
index.html: Added anid="greeting"to the.hello-tagparagraph so it can be easily targeted by JavaScript.js/script.js: Implemented a newsetGreeting()function hooked to theDOMContentLoadedevent. It checks the user's local system time and updates the greeting to either"GOOD MORNING!","GOOD AFTERNOON!", or"GOOD EVENING!".css/style.css: Increased thefont-sizeof.hello-tagto30pxto make the new dynamic greeting stand out more on the hero section. (Note: Document was also automatically formatted by my code editor).Personalizing the greeting adds a nice, interactive touch for visitors arriving at the portfolio, making the user experience feel more dynamic and welcoming.