fix(navbar): improve responsive navigation layout#48
Conversation
|
Hi @revatikadam0607 , I’ve completed the responsive navbar improvements and submitted the PR for Issue #44. Improvements Made
I’ve also attached screenshots in the PR for easier review. |
revatikadam0607
left a comment
There was a problem hiding this comment.
Hi! Thanks for pointing that out
This navbar issue was actually addressed earlier, and I’ve already made some code changes related to it.
Could you please review it again with the latest updates and let me know if the issue still persists?
Thanks for checking and helping improve the project
revatikadam0607
left a comment
There was a problem hiding this comment.
Hi!
I reviewed the changes related to the navigation layout/navbar issue, but after running the project, the entire screen is going blank.
It seems like the current changes are breaking the application. Could you please review your implementation, fix the issue, and update the PR?
Once it’s working properly, I’ll be happy to review it again.
Thanks for your effort
revatikadam0607
left a comment
There was a problem hiding this comment.
Hi! Thanks for updating the PR and working on the requested changes
I reviewed it again, and while the blank screen issue seems resolved, I noticed a couple of new issues:
- The text like “I am a Programmer” / “I am a Problem Solver” is no longer visible.
- The existing animations have been completely removed.
These were important parts of the portfolio experience, so could you please restore them and update the PR once again?
Thanks for your effort and patience — I appreciate your contribution
revatikadam0607
left a comment
There was a problem hiding this comment.
Hi! Thanks for working on this PR
I noticed that the changes are currently based on an older version of my code. The navbar and some related sections have already been updated in the latest version.
Could you please pull/use the latest codebase and make your changes on top of that version? This will help avoid conflicts and ensure your improvements align with the current UI.
Once updated, I’d be happy to review it again. Thanks
revatikadam0607
left a comment
There was a problem hiding this comment.
Hey! Thanks for contributing to the project and raising the PR. I noticed that the UI was completely changed in the update, and some of the existing animations were removed as well. The animations and overall UI style were intentional parts of the design, so I’d prefer to keep them consistent with the original look and feel.
Could you please update the PR by keeping the existing animations/UI intact while making your improvements? That would help maintain the project’s design consistency. Thanks!
|
Hi @revatikadam0607, Update
Please review the latest changes |
Fixes #44 — Responsive Navbar Improvement
Description
Improved the navbar responsiveness by displaying the navigation links horizontally on larger screens while preserving the hamburger menu behavior for smaller devices.
The implementation keeps the existing portfolio design consistent while improving overall usability, responsiveness, and navigation experience across different screen sizes.
Changes Made
Responsive Behavior
Testing Done
Screenshots
Desktop View
Mobile View
Notes
This implementation focuses on improving responsiveness and UI consistency while preserving the original project design and functionality.
Thank you forr revewing my PR!