fixed the light theme issue#22
Open
Shayan-Bhowmik wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the site’s light theme rendering by introducing additional theme-driven CSS variables (e.g., sidebar/button/background gradient secondary color) and wiring CSS to use them.
Changes:
- Added new theme variables (
--sidebar,--btn,--secondary-bg) and set them insetTheme(injs/theme.js). - Updated
bodybackground gradient to use--secondary-bginstead of a hard-coded dark color. - Updated sidebar/button styling in separate CSS files to reference the new CSS variables.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| revati-kadam-portfolio/js/theme.js | Extends setTheme to set additional CSS variables for light/dark modes. |
| revati-kadam-portfolio/css/style.css | Adds defaults for new CSS variables and uses --secondary-bg in the page background gradient. |
| revati-kadam-portfolio/css/layout.css | Switches sidebar background to var(--sidebar) (note: stylesheet not currently referenced). |
| revati-kadam-portfolio/css/components.css | Switches .skills-btn background to var(--btn) (note: stylesheet not currently referenced). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
16
| body { | ||
| margin: 0; | ||
| font-family: 'Segoe UI', sans-serif; | ||
| background: linear-gradient(135deg, var(--bg), #020617); | ||
| background: linear-gradient(135deg, var(--bg), var(--secondary-bg)); | ||
| color: var(--text); |
Comment on lines
5
to
10
| .sidebar { | ||
| width: 250px; | ||
| height: 100vh; | ||
| background: #1a1a1a; | ||
| background: var(--sidebar); | ||
| padding: 20px; | ||
| } |
Comment on lines
7
to
10
| .skills-btn { | ||
| background: #333; | ||
| background: var(--btn); | ||
| color: white; | ||
| } |
Owner
|
Thanks for the PR.. I tested it and noticed that the site is stuck in light mode...Even after selecting dark mode, it still shows the light theme. Could you please look into it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19 #NSoC '26
I have fixed the light theme issue please review it and let me know if I need to make any changes