ci: always build backend image on v* tags regardless of changed paths - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the
paths:filter from thepushtrigger of the Backend Imageworkflow so that every
v*tag push always builds and publishes itscontainer image. The
paths:filter is kept on thepull_requesttrigger.Why
GitHub applies a push
paths:filter to tag pushes as well as branch pushes.Because the release flow (
release.yml) tags whatever commit is onmain, arelease whose commit only touched
infra/was silently skipped by BackendImage and never published its versioned image. That is exactly what happened
with
v0.2.0: the release and tag exist, but no:0.2.0image was pushed toGHCR.
With this change:
type=semvermetadata maps
v0.2.1to the0.2.1image tag).mainalso always build, even infra-only commits. This is harmlessbecause the deployment image tag is content-addressed (a hash of the backend
build inputs), so an unchanged backend just republishes the same digest.
Backend Image build-only because it edits the workflow file).
Architecture impact
None. This only changes a CI trigger filter. No application code, component,
data flow, or deployment topology changes, so
docs/ARCHITECTURE.mdneeds noupdate.
Testing
v*tag pushed by the release workflow.