feat(Toast): iconPosition#623
Open
malinindev wants to merge 1 commit into
Open
Conversation
malinindev
force-pushed
the
toast-icon-align
branch
from
bae323f to
7e00978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
iconPositionprop to Toast to control where the icon is placed relative to the content. Supports"start-center","start-top","end-center","end-top".By default, the icon sits at the inline start, aligned by the toast size. With
iconPositionyou can pin it to the top for multi-line content, or move it to the inline end.Closes #605
Related Issue
#605
Screenshots / Recordings
Notes for Reviewers
icon, notstartSlot(users can wrapstartSlotthemselves).iconis at the end,startSlotcan be used alongside it."start-center"keeps the existing behavior.