Skip to content

Fix parameter type hints in EntityManager methods #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhucik wants to merge 7 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix parameter type hints in EntityManager methods #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
911438c
Fix parameter type hints in EntityManager methods
mhucik Feb 7, 2026
ee14048
Set default value of entity parameter to null
mhucik Feb 7, 2026
e88c56a
Fix variable name from nonLockingUniqueInserter to ckingUniqueInserter
mhucik Feb 7, 2026
f0c8adc
Rename ckingUniqueInserter to nonLockingUniqueInserter
mhucik Feb 7, 2026
2cb5c6c
Rename UniqueInserter to NonLockingUniqueInserter
mhucik Feb 7, 2026
570ee7d
Set default value for eventManager parameter
mhucik Feb 7, 2026
3fc2da1
Allow nullable arrays in startQuery and formatQuery
mhucik Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Kdyby/Doctrine/Diagnostics/Panel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class Panel implements IBarPanel, Doctrine\DBAL\Logging\SQLLogger
* @param array|null $params
* @param array|null $types
*/
public function startQuery($sql, array $params = NULL, array $types = NULL)
public function startQuery($sql, ?array $params = NULL, ?array $types = NULL)
{
Debugger::timer('doctrine');

Expand Down Expand Up @@ -559,7 +559,7 @@ public static function highlightQuery($sql)
* @throws \Nette\Utils\RegexpException
* @return string
*/
public static function formatQuery($query, $params, array $types = [], AbstractPlatform $platform = NULL)
public static function formatQuery($query, $params, array $types = [], ?AbstractPlatform $platform = NULL)
{
if ($platform === NULL) {
$platform = new Doctrine\DBAL\Platforms\MySqlPlatform();
Expand Down
2 changes: 1 addition & 1 deletion src/Kdyby/Doctrine/EntityManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public function newHydrator($hydrationMode)
* @throws \Doctrine\ORM\ORMException
* @return EntityManager
*/
public static function create($conn, Doctrine\ORM\Configuration $config, Doctrine\Common\EventManager $eventManager = NULL)
public static function create($conn, Doctrine\ORM\Configuration $config, ?Doctrine\Common\EventManager $eventManager = NULL)
{
if (!$config->getMetadataDriverImpl()) {
throw ORMException::missingMappingDriverImpl();
Expand Down