Visualize ROS2 IMU covariance diagnostics - #12809
Open
RitwijParmar wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
Author
|
Looks like the only remaining red check is the changelog label. I do not have label permissions here. My read is that this can be included in the changelog since it adds ROS2 IMU covariance diagnostics, but happy with whichever label maintainers prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds covariance handling to the ROS2
sensor_msgs/msg/ImuMCAP parser.covariance/*_stddevchild entitiesThis is intended as a scoped first step toward #10728 without adding a new viewer primitive or broader covariance rendering feature.
Why
Robotics users inspecting ROS2 MCAP recordings often need to debug estimator uncertainty alongside gyro/accelerometer values. Today the IMU parser drops covariance matrices entirely, so users need custom preprocessing before they can see whether an IMU stream is reporting known, missing, or changing uncertainty.
Tests
cargo test -p re_mcap covariance_stddevs --no-default-featurescargo test -p re_mcap --no-default-featuresran 42/43 tests locally. The only failure wasdecoders::attachments::tests::test_attachments_mcap_fixturewithfailed to read summary: Bad magic number, which appears unrelated to this patch and tied to the local binary fixture in this shallow clone.