Skip to content

Added check for same uris in one batch and fixed ContentItem to Conce…#99

Merged
flipsimon merged 3 commits into
mainfrom
fix_concepts
Feb 27, 2024
Merged

Added check for same uris in one batch and fixed ContentItem to Conce…#99
flipsimon merged 3 commits into
mainfrom
fix_concepts

Conversation

@flipsimon
Copy link
Copy Markdown
Contributor

@flipsimon flipsimon commented Dec 12, 2023

…pt relation bug

@flipsimon flipsimon requested a review from Frando December 12, 2023 02:00
@Frando
Copy link
Copy Markdown
Contributor

Frando commented Dec 16, 2023

We really should have tests. I think your solution should work, but I am not super confident that simply dropping previous entities from is always correct.

Can you provide a test that fails without this change and passes with the change? This would be great to have. I have another idea for a fix, but would love to test it on an actual case that currently fails.

@flipsimon
Copy link
Copy Markdown
Contributor Author

flipsimon commented Feb 27, 2024

We really should have tests. I think your solution should work, but I am not super confident that simply dropping previous entities from is always correct.

Can you provide a test that fails without this change and passes with the change? This would be great to have. I have another idea for a fix, but would love to test it on an actual case that currently fails.

Working on a peertube test: #100
Postponed for now.

@flipsimon flipsimon merged commit 0f0a3fa into main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frando Frando Awaiting requested review from Frando

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flipsimon @Frando