net: rswtich: disable GWCA when removing driver - #9
Open
lorc wants to merge 1 commit into
Open
Conversation
We need to disable GWCA for two reasons: 1. There may be packets coming to the device when U-Boot already transferred control to Linux, but Linux didn't had chance to re-configure GWCA. This may lead to memory corruption, as chains are already active. 2. Linux will not be able to switch GWCA to DISABLED state, because transition from OPERATION to DISABLED requires that all buffer pointers are released and all transactions are finished. But there are no one who can handle those operations, as U-Boot already exited and Linux is still trying to initialize R-Switch driver. This fixes issue with DomD unable to initialize network in the parallel mode. Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Collaborator
|
Hi @lorc, Thanks for your input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to disable GWCA for two reasons:
There may be packets coming to the device when U-Boot already transferred control to Linux, but Linux didn't had chance to re-configure GWCA. This may lead to memory corruption, as chains are already active.
Linux will not be able to switch GWCA to DISABLED state, because transition from OPERATION to DISABLED requires that all buffer pointers are released and all transactions are finished. But there are no one who can handle those operations, as U-Boot already exited and Linux is still trying to initialize R-Switch driver.
This fixes issue with DomD unable to initialize network in the parallel mode.
Signed-off-by: Volodymyr Babchuk volodymyr_babchuk@epam.com