net: tftp: Fix incorrect tftp_next_ack on no OACK - #8
Conversation
When the tftp server did not send any OACK, the tftp_next_ack variable was not set to the correct value . As the server was transmitting blocks we generated a lot of 'Received unexpected block: $n, expected $n+1' error messages. Depending on the timeout setting the transfer could still complete though. Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com> CC: Ramon Fried <rfried.dev@gmail.com> Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
|
Hello @lorc |
|
Hi @HaiNguyenPham.
Yes, this is correct.
I'm not sure, but this looks like valid fix, so it is better to include this as well. Also, please note that patch in this PR is not authored by me. I took it from upstream U-Boot code. |
|
Hi @lorc |
3 participants
When the tftp server did not send any OACK, the tftp_next_ack variable
was not set to the correct value . As the server was transmitting
blocks we generated a lot of 'Received unexpected block: $n, expected
$n+1' error messages. Depending on the timeout setting the transfer
could still complete though.
Signed-off-by: Harm Berntsen harm.berntsen@nedap.com
CC: Ramon Fried rfried.dev@gmail.com
Reviewed-By: Ramon Fried rfried.dev@gmail.com
It appears that some old TFTP server do not support OPTIONS extension for the protocol, which causes problems in our case.