[KEYS-910] Add support for persistence mode to Key Value#92
Open
jburianek wants to merge 1 commit into
Open
Conversation
jburianek
requested review from
jakemalachowski,
kitemongerer,
mdbenjam and
wendorf
as code owners
kitemongerer
left a comment
kitemongerer
left a comment
Contributor
There was a problem hiding this comment.
How have you tested this? Have you confirmed that creating a keyval with a prior TF version and then running with this version works as expected
wendorf
approved these changes
Jun 16, 2026
wendorf
left a comment
wendorf
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! This isn't my strongest codebase, though, so I'd prefer waiting for a second reviewer before merging
|
|
||
| resource.TestCheckResourceAttrWith(resourceName, "connection_info.redis_cli_command", func(value string) error { | ||
| if !regexp.MustCompile(`^ REDISCLI_AUTH=.{32} redis-cli --user red-[a-z0-9]+ -h .*-.*.com -p 637[7|9] --tls$`).MatchString(value) { | ||
| if !regexp.MustCompile(`^ REDISCLI_AUTH=.{32} valkey-cli --user red-[a-z0-9]+ -h .*-.*.com -p 637[7|9] --tls$`).MatchString(value) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the new Key Value
persistenceModesetting.Paid Render Key Value instances now support three different disk persistence modes:
This matches the behavior of all paid Key Value instances previously
More details are in the change log and docs. The REST API docs have also been updated.