fix(#51): fixed type hints of models - #52
Merged
Merged
Conversation
Contributor
|
Sorry, I think I've lost track of which issue these changes are trying to address. I did wonder if it was neccesary to have aliases for each case, as unlike how it used to be with Oracle, SQL Server is configured to use case insensitive object names. |
Contributor
Author
|
This came up in updating nhsbt_import, where it was missing required fields, but when checking the db some fields could be nullable, so this was just to align the models with what is in the database |
Contributor
|
Ahh right - I see now what's actually changed. That seems fine. It was having... That puzzled me, but as it's already like that I'll approve the PR. |
George-D-S
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.