Skip to content

fix(#51): fixed type hints of models - #52

Merged
OliveraReeves merged 2 commits into
mainfrom
#51
Apr 27, 2026
Merged

fix(#51): fixed type hints of models#52
OliveraReeves merged 2 commits into
mainfrom
#51

Conversation

@OliveraReeves

Copy link
Copy Markdown
Contributor

No description provided.

@George-D-S

Copy link
Copy Markdown
Contributor

Sorry, I think I've lost track of which issue these changes are trying to address.

I did wonder if it was neccesary to have aliases for each case, as unlike how it used to be with Oracle, SQL Server is configured to use case insensitive object names.

@OliveraReeves

Copy link
Copy Markdown
Contributor Author

This came up in updating nhsbt_import, where it was missing required fields, but when checking the db some fields could be nullable, so this was just to align the models with what is in the database

@George-D-S

Copy link
Copy Markdown
Contributor

Ahh right - I see now what's actually changed. That seems fine.

It was having...

    SURNAME: Mapped[Optional[str]] = mapped_column(String(50))
    surname: Mapped[Optional[str]] = synonym("SURNAME")

That puzzled me, but as it's already like that I'll approve the PR.

@OliveraReeves
OliveraReeves merged commit f88374d into main Apr 27, 2026
3 checks passed
@OliveraReeves
OliveraReeves deleted the #51 branch April 27, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants