Fix the CheckESPTimeout and its constant, remove WaitRaster, add init empty Rx FIFO#9
Open
janko-jj wants to merge 2 commits into
Open
Fix the CheckESPTimeout and its constant, remove WaitRaster, add init empty Rx FIFO#9janko-jj wants to merge 2 commits into
janko-jj wants to merge 2 commits into
Conversation
With the WaitRaster and the big constant the timeout became infinity in practice. Therefore after the constant calculation is corrected the WaitRaster is removed. The timeout is set to 60 seconds at 28MHz
Owner
|
Where you able to test against the original issue? #7 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


As each WaitRaster causes up to a whole frame busy wait, the constant used for timeout produced a practically infinite wait in 1.1.0. Here WaitRaster is removed from CheckESPTimeout , and instead the constant calculation adjusted to specify the timeout in seconds. As many seconds are needed for slow requests over the internet, a timeout constant of 60 seconds (in 28MHz mode) is specified to also comply with the reason which lead to the introduction of WaitRaster.
Also an UART init is adjusted to perform fast emptying of Rx FIFO at the start.