Skip to content

fix: link vcpkg static libroaring by exact path #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GavinPizza wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: link vcpkg static libroaring by exact path #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pg_ducklake/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,13 @@ endif
# resolves static archives in a single left-to-right pass.
PG_DUCKLAKE_LINK_FLAGS += -lssl -lcrypto -lstdc++ -llz4
ifneq ($(ROARING_LIB_DIR),)
PG_DUCKLAKE_LINK_FLAGS += -L$(ROARING_LIB_DIR)
# Link the vcpkg static archive by exact path: the pgxs -L/usr/lib prefix
# otherwise wins the search order and binds -lroaring to the ancient system
# libroaring.so (0.2.66), which lacks symbols like roaring_free.
PG_DUCKLAKE_LINK_FLAGS += $(ROARING_LIB_DIR)/libroaring.a
else
PG_DUCKLAKE_LINK_FLAGS += -lroaring
endif
PG_DUCKLAKE_LINK_FLAGS += -lroaring
ifneq ($(shell uname -s),Darwin)
PG_DUCKLAKE_LINK_FLAGS += -Wl,--exclude-libs,ALL
endif
Expand Down
Loading