fix(config): stop save corrupting configs not indented with 2 spaces#914
Merged
Conversation
Service.MarshalYAML pre-marshalled itself to bytes at the marshal-default 2-space indent, so on configs using any other indentation, goccy spliced a mixed-indent subtree into the document. Save's line-based cleanup (reorderYAML) then misread the indent levels and stripped all keys on the next level (e.g. `options`, `latest_version`, `deployed_version`, ...), flattening the service block into a config that failed to parse/validate on the next start. Marshal Service via yaml.InterfaceMarshaler instead, returning a value for the enclosing encoder to marshal, so the document's encode options (indentation) also apply to the Service subtree.
Argus-Bot
approved these changes
Jul 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 199 199
Lines 12721 12721
=======================================
Hits 12683 12683
Misses 33 33
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Playwright Test Results
Duration: 962.5s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service.MarshalYAML pre-marshalled itself to bytes at the marshal-default 2-space indent, so on configs using any other indentation, goccy spliced a mixed-indent subtree into the document. Save's line-based cleanup (reorderYAML) then misread the indent levels and stripped all keys on the next level (e.g.
options,latest_version,deployed_version, ...), flattening the service block into a config that failed to parse/validate on the next start.Marshal Service via yaml.InterfaceMarshaler instead, returning a value for the enclosing encoder to marshal, so the document's encode options (indentation) also apply to the Service subtree.
fixes #910