Skip to content

Fix data-driven-dependencies example app#348

Merged
captbaritone merged 1 commit into
relayjs:mainfrom
captbaritone:fix-data-driven-dependencies
Jun 16, 2026
Merged

Fix data-driven-dependencies example app#348
captbaritone merged 1 commit into
relayjs:mainfrom
captbaritone:fix-data-driven-dependencies

Conversation

@captbaritone

Copy link
Copy Markdown
Contributor

Summary

  • Remove hardcoded GRAPHQL_ENDPOINT env var and instead construct the URL from PORT, falling back to 3000
  • Add webpack alias for react and react-dom to resolve duplicate React instances when using linked packages
  • Import path module in next.config.js for the alias resolution

Test plan

  • Run yarn install and yarn dev in data-driven-dependencies/
  • Verify the app starts and loads correctly on the default port
  • Verify setting a custom PORT env var is respected

@meta-cla meta-cla Bot added the CLA Signed label Jun 16, 2026
@captbaritone captbaritone merged commit f53016d into relayjs:main Jun 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant