Remove _FALLBACK_ADAPTER_TYPES curated fallback#307
Merged
Conversation
adapter list-types now derives the supported type list (and per-type description) solely from the live cloud_sensor/external_adapter hive JSON-Schema. The hard-coded fallback only ever masked backend downtime, during which every other command fails anyway, so a stale list would only mislead. If the schema can't be fetched the error now surfaces. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfrssJQLhNEFhvaUr1EPzv
lcbill
previously approved these changes
Jun 19, 2026
The live hive schema does not carry per-type descriptions; descriptions only ever came from the curated fallback dict that this PR removes. Rather than emit a permanently-empty "description" column, list-types now returns just the type name. Reverts _types_from_schema to its plain list return as well. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfrssJQLhNEFhvaUr1EPzv
lcbill
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
adapter list-types(cloud-adapter & external-adapter) used to fall back to a hard-coded_FALLBACK_ADAPTER_TYPESdict whenever the live hive JSON-Schema couldn't be fetched. This removes that fallback entirely.Why
The fallback only kicked in when the backend was unavailable — and during downtime every other command fails anyway, so a stale, manually-maintained list just misleads. The type list now comes solely from the live
cloud_sensor/external_adapterhive schema. If the schema can't be fetched, the error surfaces instead of being swallowed.The hard-coded list was in fact already stale: tested live against an org, the schema advertises types the dict never had (
bitwarden,box,cylance,defender,falconcloud,sentinel_one,trend_micro,zendesk, …).Changes
_FALLBACK_ADAPTER_TYPESconstant and the_describe()helper.adapter_types()derives from the schema only and raises (ClickException) if it can't.descriptioncolumn: descriptions only ever came from the curated dict — the live schema carries none, so the column was permanently empty.list-typesnow returns just the type name.Tested
Live against an org via the dev CLI: both
cloud-adapter list-typesandexternal-adapter list-typesreturn the full live type set (34 / 45 types), table + json render correctly, and theschema --type <unknown>error still enumerates valid types.🤖 Generated with Claude Code
https://claude.ai/code/session_01EfrssJQLhNEFhvaUr1EPzv