feat(ui): add Rank column and enable sorting in vector set similarity results#5973
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0deb2c0. Configure here.
Contributor
Code Coverage - Frontend unit tests
Test suite run success7023 tests passing in 805 suites. Report generated by 🧪jest coverage report action from b65d19e |
pawelangelow
previously approved these changes
May 28, 2026
Contributor
pawelangelow
left a comment
There was a problem hiding this comment.
Looks good! 🚀 There are still a couple of valid Cursor suggestions to clean up, but after that, I’m good to approve again.
valkirilov
previously approved these changes
May 28, 2026
0deb2c0 to
b65d19e
Compare
pawelangelow
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
rankon eachVectorSetSimilarityMatchin the BE response order (in the slice reducer), so rank stays independent of the table's client-side sort.#Nbadge per row and moves the Similarity column to the rightmost position. Column order is nowElement, …attributes(α), Rank, Similarity.Test plan
#1, #2, ...in BE order, Similarity column is the last column.yarn test(45 + 58 = 103 tests in scope, all green locally).🤖 Generated with Claude Code
Note
Low Risk
Browser-only vector-set similarity UI and Redux shaping; no auth, API contract, or data-mutation changes beyond stamping rank on search success.
Overview
Adds 1-based rank on each similarity match when search results land in Redux (backend response order), so rank stays on the row when the table is sorted client-side.
The results table gets a Rank column (
#Nbadges), Similarity moves to the far right (Element→ attribute columns →Rank→Similarity), and header sorting is turned on for Element, Rank, Similarity, and dynamic attribute columns. Attribute sorting uses memoizedgetParsedAttributesso JSON is not re-parsed on every compare.Column visibility treats Rank like Element and Similarity (always shown); min-width math includes the new column. Tests cover reducer stamping, column order, and
getParsedAttributescaching.Reviewed by Cursor Bugbot for commit b65d19e. Bugbot is set up for automated code reviews on this repo. Configure here.