RI-8197: Command Helper - Vector Set commands support#5955
Conversation
dantovska
changed the title
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
The redis/redis-doc repo is no longer maintained. Point the main and module commands URLs at the official redis/docs repo, which now hosts the canonical commands.json files (and includes Vector Set commands in commands_core.json). RedisGraph and RedisGears URLs are left as-is — no equivalents in redis/docs since both modules are EOL.
Vector Set commands (VADD, VSIM, VCARD, ...) ship in commands_core.json under group "module". Add a CommandGroup.VectorSet enum keyed to that value, plus a display label and color in GROUP_TYPES_DISPLAY / GROUP_TYPES_COLORS, so the Command Helper filter dropdown surfaces them under their own "Vector Set" entry instead of a generic "module" label.
Long type labels (e.g. "Vector Set") were wrapping mid-word in the Command Helper info row when the args text next to the badge was long. Set flex-shrink: 0 and white-space: nowrap on the badge so the label stays on one line and the variable-length args text takes the overflow.
Tracking redis/docs main means any schema or content change there silently ships in the next build. Factor the SHA into a single REDIS_DOCS_COMMANDS_SHA constant + redisDocsCommandsUrl() helper so all five commands_*.json URLs resolve against a pinned commit, and a future bump workflow can update the line deterministically.
dantovska
force-pushed
the
feature/RI-8197/command-helper-vector-set
branch
from
1a6f4d4 to
e912f17
Compare
Adds scripts/bump-commands-pin.mjs and a scheduled workflow that runs weekly (Mon 06:00 UTC) plus on manual dispatch. The script reads the current REDIS_DOCS_COMMANDS_SHA from redisinsight/api/config/default.ts, fetches the latest commit on redis/docs main, diffs all five commands_*.json files at the two SHAs, and only opens a PR when the JSON content actually changed (SHA-only moves are skipped). The PR body summarises commands added / removed / schema-changed per file so a reviewer can decide whether to merge. Requires the REDIS_DOCS_COMMANDS_SHA constant introduced in #5955.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e912f17. Configure here.
| TopK = 'topk', | ||
| BloomFilter = 'bf', | ||
| CuckooFilter = 'cf', | ||
| VectorSet = 'module', |
There was a problem hiding this comment.
VectorSet enum value likely wrong group identifier
High Severity
CommandGroup.VectorSet is mapped to the string 'module', but according to the official Redis documentation, vector set commands (VADD, VSIM, etc.) belong to the "vector_set" group. All other module command groups in this codebase use their specific group identifiers ('search', 'json', 'timeseries', 'bf', 'cf'), not the generic 'module'. If the upstream commands_core.json uses "vector_set", the Command Helper filter will match nothing when "Vector Set" is selected, the badge color won't apply, and the display label will fall back to lowercase "vector set" via type.replace(/_/g, ' ').
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e912f17. Configure here.
Code Coverage - Backend unit tests
Test suite run success3436 tests passing in 307 suites. Report generated by 🧪jest coverage report action from e912f17 |
Code Coverage - Integration Tests
|
Code Coverage - Frontend unit tests
Test suite run success6965 tests passing in 802 suites. Report generated by 🧪jest coverage report action from e912f17 |
ArtemHoruzhenko
left a comment
ArtemHoruzhenko
left a comment
There was a problem hiding this comment.
We can't do this
4 participants
Summary
Adds Vector Set commands (VADD, VSIM, VCARD, VDIM, ...) to the Command Helper.
redis/redis-doc(and the per-module RedisJSON/RedisSearch/etc. repos) to the officialredis/docsrepo. Vector Set commands ship incommands_core.jsonthere.Vector Setcommand group: addsCommandGroup.VectorSet(keyed to the upstreammodulegroup value), a display label, and a color so the Command Helper filter dropdown lists vector set commands under their own group.Test plan
Note
Medium Risk
Switches the default command metadata sources to pinned
redis/docsJSON endpoints, which can affect Command Helper command coverage/format if the upstream data changes or the pin is bumped. UI changes are minor but touch shared constants used for grouping and styling.Overview
Command Helper now supports Vector Set commands by introducing a new
CommandGroup.VectorSet(mapped to upstreammodule) and wiring in its display label and color so it appears as a first-class group in filtering/UI.Command metadata fetching is updated: default command JSON URLs for core/Search/JSON/TimeSeries/Bloom are switched from various legacy repos to a pinned commit in
redis/docsvia a centralized URL builder.Minor UI polish:
GroupBadgestyling is adjusted (flex-shrink: 0,white-space: nowrap) to prevent long group labels like “Vector Set” from wrapping.Reviewed by Cursor Bugbot for commit e912f17. Bugbot is set up for automated code reviews on this repo. Configure here.