Skip to content

applyOutputs: Handle conflict with retry instead of error#117

Closed
kdorosh wants to merge 4 commits into
mainfrom
handle_conflict_errs
Closed

applyOutputs: Handle conflict with retry instead of error#117
kdorosh wants to merge 4 commits into
mainfrom
handle_conflict_errs

Conversation

@kdorosh

@kdorosh kdorosh commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

💸 TL;DR

This PR updates the reconcile function to handle conflict errors with a retry instead of an error.

edit: related PR: #116

📜 Details

This PR updates the reconcile function to handle conflict errors with a retry instead of an error. This is useful as it automatically signals the retry (which should eventually work, as reconcile read's the object before it applies) and it prevents controller_runtime_reconcile_errors_total from erroneously increasing, which can lead to false positives in alerting.

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee (N/A: Reddit employee)

@kdorosh

kdorosh commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

closing in favor of #116

@kdorosh kdorosh closed this Jun 1, 2026
@kdorosh kdorosh deleted the handle_conflict_errs branch June 1, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant