Removes HockeyApp use#635
Open
markholland wants to merge 5 commits into
Open
Conversation
markholland
requested review from
robbiemccorkell
and removed request for
robbiemccorkell
markholland
commented
Dec 17, 2018
| new_devices = get_unprovisioned_devices_from_hockey(app_bundle_id:'org.prideinlondon.festival', api_token:options[:api_token]) | ||
| register_devices(devices: new_devices) | ||
| register_devices(devices: { | ||
| "Example device name" => "Example UUID", |
Contributor
Author
There was a problem hiding this comment.
See for example https://docs.fastlane.tools/actions/register_devices/#4-examples
Contributor
Author
|
No rush to merge this as still useful. |
…app into remove-hockeyapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #631
Removes uploading builds to HockeyApp and querying for registered devices
Pre-flight check-list
Before raising a pull request
Pre-merge check-list
Tester check-list
Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):
Optional:
Accessibility Testing (If applicable)
Weak connection testing (If applicable)