Skip to content

Add same background to App as Spash on android#594

Open
RGBboy wants to merge 2 commits into
masterfrom
gh-591-app-background-color
Open

Add same background to App as Spash on android#594
RGBboy wants to merge 2 commits into
masterfrom
gh-591-app-background-color

Conversation

@RGBboy

@RGBboy RGBboy commented Jul 6, 2018

Copy link
Copy Markdown
Contributor

Fixes #591. This should fix the white screen flash Android users see when updating the app. This does not seem to happen when opening an already installed app (that has been opened before) Note: There is still a fade of solid color. I'm not sure how to get rid of this.

In order to test you will need to uninstall the app an reinstall it.

Tester check-list

  • Tested on a number of Android devices:

    • Galaxy S8 (Android 7.0/8.0)
    • Galaxy S7 (Android 6.0)

    Optional:

    • Google Pixel 2
    • Galaxy S8 Plus
    • Galaxy S7 Edge
    • Galaxy S6

@RGBboy RGBboy changed the title add same background to App as Spash on android; Add same background to App as Spash on android Jul 6, 2018
@stevecottle

Copy link
Copy Markdown

Checked this and is an improvement on the white 👍

@frigus02

Copy link
Copy Markdown
Contributor

Hm, I think the better option would be to set the SplashTheme as the application/android:theme here:

android:theme="@style/AppTheme">

Because we use the clean AppTheme once the SplashScreen activity has been loaded:

I think this is important in case we have any transparent views in React Native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading screen: White screen appears half way through loading

3 participants