Introduce cross-platform shell core#560
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d43a17fa07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .paneEqualizeSplits, | ||
| .paneZoom, | ||
| .paneUnzoom, | ||
| .terminalSendText, |
There was a problem hiding this comment.
Route terminal.send_text through the host handler
When a control-file command uses terminal.send_text, ShellControlPlane.responseForPolledCommand tries socketServer.handleLocally before the host commandHandler; adding .terminalSendText here makes AlanShellLocalCommandExecutor consume the command and return a sendText side effect. However ShellControlPlane constructs the socket server with sideEffectHandler: { _ in }, so the side effect is dropped and the host path in ShellHostControlCommandHandling that actually writes to TerminalRuntimeRegistry is skipped. In that polled-command context, the response can report success while no bytes are delivered.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Validation
Note: test-shell-settings-surface.sh first hit a transient Clang module-cache rename error while several Swift scripts ran in parallel; a separate rerun passed.