Builds: isolated builders (development environment)#311
Open
humitos wants to merge 17 commits into
Open
Conversation
Small changes to use `readthedocs-builder` repository to isolate builds.
humitos
commented
Jul 14, 2026
humitos
changed the title
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Jul 14, 2026
agjohnson
reviewed
Jul 14, 2026
| # mount as populated and skips ``git clone`` so you can iterate | ||
| # on the runner / worker code by editing on the host and | ||
| # restarting the container. | ||
| - ${PWD}/${RTDDEV_PATH_BUILDER:-../readthedocs-builder}:/opt/readthedocs-builder |
Contributor
There was a problem hiding this comment.
This seems not super consistent, why the different path in /opt/ here? We're using /usr/src/app/ for the app, why not /usr/src/builder/?
Comment on lines
+411
to
+412
| # The entrypoint script itself, bind-mounted so edits don't | ||
| # need a rebuild (matches how celery.sh / build.sh wire up). |
Contributor
There was a problem hiding this comment.
How is this different from the normal pattern used in other services in this file?
Speaking generally on what I assume llm generated code, I think this is a case of overly verbose commenting from the llm. I'm noticing similar in a lot of output. Having a lot of comments to wade through actually makes it more confusing and harder work to process. We don't note these things anywhere else in the file, so I need to read through all these comments to figure out what is actually important and different from the rest of the file.
Comment on lines
+437
to
+444
| # Runner venv + managed Python install: host-daemon-recognized | ||
| # names of the named volumes defined at the top of this file. | ||
| # Compose prefixes volume names with the project (``community`` | ||
| # for the default community-edition project). The worker passes | ||
| # these as ``-v <name>:<path>:ro`` and the daemon resolves them | ||
| # as named-volume mounts. | ||
| - RTD_HOST_RUNNER_VENV_PATH=community_runner-venv | ||
| - RTD_HOST_PYTHON_INSTALL_PATH=community_uv-python |
Contributor
There was a problem hiding this comment.
The comment here isn't super clear. If these are volumes, then why are they referred to as paths? Shouldn't this be:
Suggested change
| # Runner venv + managed Python install: host-daemon-recognized | |
| # names of the named volumes defined at the top of this file. | |
| # Compose prefixes volume names with the project (``community`` | |
| # for the default community-edition project). The worker passes | |
| # these as ``-v <name>:<path>:ro`` and the daemon resolves them | |
| # as named-volume mounts. | |
| - RTD_HOST_RUNNER_VENV_PATH=community_runner-venv | |
| - RTD_HOST_PYTHON_INSTALL_PATH=community_uv-python | |
| # Runner venv + managed Python install: host-daemon-recognized | |
| # names of the named volumes defined at the top of this file. | |
| # Compose prefixes volume names with the project (``community`` | |
| # for the default community-edition project). The worker passes | |
| # these as ``-v <name>:<path>:ro`` and the daemon resolves them | |
| # as named-volume mounts. | |
| - RTD_HOST_RUNNER_VENV_VOLUME=community_runner-venv | |
| - RTD_HOST_PYTHON_INSTALL_VOLUME=community_uv-python |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by: readthedocs/readthedocs.org#13133