Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ namespace facebook::react {
* constructor. The callable returns a unique pointer conveniently represents an
* abstract type and ownership of the newly created object.
*/
using ComponentDescriptorConstructor = ComponentDescriptor::Unique(const ComponentDescriptorParameters &parameters);
using ComponentDescriptorConstructor =
std::function<ComponentDescriptor::Unique(const ComponentDescriptorParameters &parameters)>;

/*
* Represents a unified way to construct an instance of a particular stored
Expand All @@ -35,7 +36,7 @@ class ComponentDescriptorProvider final {
ComponentHandle handle;
ComponentName name;
ComponentDescriptor::Flavor flavor;
ComponentDescriptorConstructor *constructor;
ComponentDescriptorConstructor constructor;
};

/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ void ComponentDescriptorRegistry::add(
const ComponentDescriptorProvider& componentDescriptorProvider) const {
std::unique_lock lock(mutex_);

auto componentDescriptor = componentDescriptorProvider.constructor(
{.eventDispatcher = parameters_.eventDispatcher,
.contextContainer = parameters_.contextContainer,
.flavor = componentDescriptorProvider.flavor});
auto args = ComponentDescriptorParameters{
.eventDispatcher = parameters_.eventDispatcher,
.contextContainer = parameters_.contextContainer,
.flavor = componentDescriptorProvider.flavor};
auto componentDescriptor = componentDescriptorProvider.constructor(args);
react_native_assert(
componentDescriptor->getComponentHandle() ==
componentDescriptorProvider.handle);
Expand All @@ -45,6 +46,7 @@ void ComponentDescriptorRegistry::add(

auto sharedComponentDescriptor = std::shared_ptr<const ComponentDescriptor>(
std::move(componentDescriptor));

_registryByHandle[componentDescriptorProvider.handle] =
sharedComponentDescriptor;
_registryByName[componentDescriptorProvider.name] = sharedComponentDescriptor;
Expand Down
Loading