Animated: Trigger Callback on Stopping Native Loops#52274
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
0601868 to
d8b66c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
d8b66c6 to
0a6aca9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
0a6aca9 to
38049e0
Compare
38049e0 to
e1a879b
Compare
Summary: Pull Request resolved: react#52274 Currently, `callback` in `Animated.loop(animation).start(callback)` does not get triggered when calling `stop()` if `animation` uses native driver. This diff implements that functionality. Changelog: [General][Changed] - Stopping an `Animated.loop` for a native animation will now correctly trigger completion callbacks supplied to `start()`. Reviewed By: javache Differential Revision: D77329013
|
This pull request was exported from Phabricator. Differential Revision: D77329013 |
e1a879b to
887678f
Compare
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
|
Hi @yungsters! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Closing this PR as the diff D77329013 has been abandoned internally. |
Summary:
Currently,
callbackinAnimated.loop(animation).start(callback)does not get triggered when callingstop()ifanimationuses native driver.This diff implements that functionality.
Changelog:
[General][Changed] - Stopping an
Animated.loopfor a native animation will now correctly trigger completion callbacks supplied tostart().Differential Revision: D77329013