Skip to content

Ship fixMountingCoordinatorReportedPendingTransactionsOnAndroid feature flag by default #50523

Closed
rubennorte wants to merge 1 commit into from
Closed

Ship fixMountingCoordinatorReportedPendingTransactionsOnAndroid feature flag by default #50523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<7c6e2d01585686b614664672367e9107>>
* @generated SignedSource<<7f3dba37b181d001a7f90d2e0e7a6452>>
*/

/**
Expand Down Expand Up @@ -77,7 +77,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean = false

override fun fixMountingCoordinatorReportedPendingTransactionsOnAndroid(): Boolean = false
override fun fixMountingCoordinatorReportedPendingTransactionsOnAndroid(): Boolean = true

override fun fuseboxEnabledRelease(): Boolean = false

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<2fc4a56feb9686df603170c2ec8295ab>>
* @generated SignedSource<<d1f0ac93da2872e97ca83926348d1cce>>
*/

/**
Expand Down Expand Up @@ -136,7 +136,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool fixMountingCoordinatorReportedPendingTransactionsOnAndroid() override {
return false;
return true;
}

bool fuseboxEnabledRelease() override {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,15 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
fixMountingCoordinatorReportedPendingTransactionsOnAndroid: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2024-08-27',
description:
'Fixes a limitation on Android where the mounting coordinator would report there are no pending transactions but some of them were actually not processed due to the use of the push model.',
expectedReleaseValue: true,
purpose: 'experimentation',
},
ossReleaseStage: 'none',
ossReleaseStage: 'stable',
},
fuseboxEnabledRelease: {
defaultValue: false,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<90b82671674512dc6bed998c9a1c9a5a>>
* @generated SignedSource<<f20f2f58a3ee800913a15ab63e64f282>>
* @flow strict
*/

Expand Down Expand Up @@ -269,7 +269,7 @@ export const fixMappingOfEventPrioritiesBetweenFabricAndReact: Getter<boolean> =
/**
* Fixes a limitation on Android where the mounting coordinator would report there are no pending transactions but some of them were actually not processed due to the use of the push model.
*/
export const fixMountingCoordinatorReportedPendingTransactionsOnAndroid: Getter<boolean> = createNativeFlagGetter('fixMountingCoordinatorReportedPendingTransactionsOnAndroid', false);
export const fixMountingCoordinatorReportedPendingTransactionsOnAndroid: Getter<boolean> = createNativeFlagGetter('fixMountingCoordinatorReportedPendingTransactionsOnAndroid', true);
/**
* Flag determining if the React Native DevTools (Fusebox) CDP backend should be enabled in release builds. This flag is global and should not be changed across React Host lifetimes.
*/
Expand Down