Skip to content

Add I18nManager docs#4626

Merged
Abbondanzo merged 1 commit into
react:mainfrom
scarlac:main
Jun 4, 2025
Merged

Add I18nManager docs#4626
Abbondanzo merged 1 commit into
react:mainfrom
scarlac:main

Conversation

@scarlac

@scarlac scarlac commented May 28, 2025

Copy link
Copy Markdown
Contributor

Added to sidebar as well.
Related to react/react-native#51661 and react/react-native#51648

@netlify

netlify Bot commented May 28, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit f1c3d2e
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/683f5d0e3e42d30008ebca07
😎 Deploy Preview https://deploy-preview-4626--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@scarlac scarlac force-pushed the main branch 2 times, most recently from 23ea9a8 to 09bbefa Compare May 28, 2025 20:45
@scarlac

scarlac commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

I'm not sure how I can address the build issue. I can reproduce it locally but the error doesn't make sense to me:

$ yarn && cd website && yarn build
...
Successfully generated output from ./sidebarsArchitecture.ts
{
  "totalUrls": 13,
  "unavailableUrls": []
}
Successfully generated output from ./sidebarsContributing.ts
{
  "totalUrls": 147,
  "unavailableUrls": [
    {
      "url": "https://reactnative.dev/docs/i18nmanager",
      "status": 404,
      "error": null
    }
  ]
}
Documentation generation skipped due to broken links

I don't see any direct or indirect mentions of i18nmanager in sidebarsContributing.ts
Any help is appreciated.

@Abbondanzo

Copy link
Copy Markdown
Contributor

I'm not sure how I can address the build issue. I can reproduce it locally but the error doesn't make sense to me:

I just dealt with this in #4623. The fix required landing the same docs into 0.79's versioned_docs first before adding it to the sidebar

cc @szymonrybczak do you think you could make changes to your llm script to take new sidebar links into account to prevent blocking builds?

@szymonrybczak

szymonrybczak commented May 31, 2025

Copy link
Copy Markdown
Contributor

@Simek is there any way we could inject some env variable to the generate-llms-txt.js script with current deployment url, because it'll always fail on the PR branches. (even if we would check with /next prefix in the URL

@Simek

Simek commented Jun 1, 2025

Copy link
Copy Markdown
Collaborator

@szymonrybczak It looks like you should be able to access the deployment URL via env vars according to:

Not sure tho, if this will be available before app build finishes, but let's tests it out.

@scarlac

scarlac commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

@Abbondanzo added here:
#4627

@scarlac

scarlac commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for fixing the checks, @Simek . Looks like it passed now

@Abbondanzo Abbondanzo enabled auto-merge (squash) June 4, 2025 04:04
@Abbondanzo Abbondanzo merged commit 2ff5c7a into react:main Jun 4, 2025
4 checks passed
coado pushed a commit to coado/react-native-website that referenced this pull request Jun 30, 2025
Added to sidebar as well.
Related to react/react-native#51661 and react/react-native#51648

Co-authored-by: Seph Soliman <sesoliman@tesla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants