Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@
},
"dependencies": {
"@rc-component/mini-decimal": "^1.1.1",
"@rc-component/util": "^1.4.0",
"@rc-component/util": "^1.11.1",
"clsx": "^2.1.1"
},
"devDependencies": {
"@rc-component/father-plugin": "^2.0.2",
"@rc-component/father-plugin": "^2.2.0",
"@rc-component/np": "^1.0.3",
"@swc-node/jest": "^1.5.5",
"@testing-library/jest-dom": "^6.1.5",
Expand Down
11 changes: 7 additions & 4 deletions src/InputNumber.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,19 @@ import getMiniDecimal, {
validateNumber,
ValueType,
} from '@rc-component/mini-decimal';
import { useLayoutUpdateEffect } from '@rc-component/util/lib/hooks/useLayoutEffect';
import proxyObject from '@rc-component/util/lib/proxyObject';
import {
type InputFocusOptions,
proxyObject,
triggerFocus,
useEvent,
useLayoutUpdateEffect,
} from '@rc-component/util';
import { clsx } from 'clsx';
import * as React from 'react';
import useCursor from './hooks/useCursor';
import StepHandler from './StepHandler';
import { getDecupleSteps } from './utils/numberUtil';

import { useEvent } from '@rc-component/util';
import { triggerFocus, type InputFocusOptions } from '@rc-component/util/lib/Dom/focus';
import useFrame from './hooks/useFrame';

export type { ValueType };
Expand Down
2 changes: 1 addition & 1 deletion src/StepHandler.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable react/no-unknown-property */
import raf from '@rc-component/util/lib/raf';
import { raf } from '@rc-component/util';
import { clsx } from 'clsx';
import * as React from 'react';

Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useCursor.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { warning } from '@rc-component/util';
import { useRef } from 'react';
import warning from '@rc-component/util/lib/warning';
/**
* Keep input cursor in the correct position if possible.
* Is this necessary since we have `formatter` which may mass the content?
Expand Down
4 changes: 2 additions & 2 deletions src/hooks/useFrame.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useRef, useEffect } from 'react';
import raf from '@rc-component/util/lib/raf';
import { raf } from '@rc-component/util';
import { useEffect, useRef } from 'react';

/**
* Always trigger latest once when call multiple time
Expand Down
6 changes: 3 additions & 3 deletions tests/click.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from 'react';
import { render, fireEvent, act } from '@testing-library/react';
import InputNumber, { InputNumberProps } from '../src';
import KeyCode from '@rc-component/util/lib/KeyCode';
import { KeyCode } from '@rc-component/util';

jest.mock('@rc-component/mini-decimal/lib/supportUtil');
const { supportBigInt } = require('@rc-component/mini-decimal/lib/supportUtil');
Expand Down Expand Up @@ -37,7 +37,7 @@ describe('InputNumber.Click', () => {
fireEvent.click(container.querySelector(selector));
expect(onChange).toHaveBeenCalledTimes(1);
expect(onChange).toHaveBeenCalledWith(changedValue);
expect(onStep).toHaveBeenCalledWith(changedValue, { offset: 1, type: stepType, emitter });
expect(onStep).toHaveBeenCalledWith(changedValue, { offset: 1, type: stepType, emitter });
unmount();
});
}
Expand Down Expand Up @@ -186,7 +186,7 @@ describe('InputNumber.Click', () => {
});

expect(onChange).toHaveBeenCalledWith(1.1);
expect(onStep).toHaveBeenCalledWith(1.1, { offset: '0.1', type: 'down', emitter: 'keyboard' });
expect(onStep).toHaveBeenCalledWith(1.1, { offset: '0.1', type: 'down', emitter: 'keyboard' });
});

it('click up button with pressing shift key', () => {
Expand Down
48 changes: 27 additions & 21 deletions tests/cursor.test.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { KeyCode } from '@rc-component/util';
import React from 'react';
import KeyCode from '@rc-component/util/lib/KeyCode';
import { render, fireEvent } from './util/wrapper';
import InputNumber from '../src';
import { fireEvent, render } from './util/wrapper';

describe('InputNumber.Cursor', () => {
function cursorInput(input: HTMLInputElement, pos?: number) {

if (pos !== undefined) {
input.setSelectionRange(pos, pos);
}
Expand All @@ -17,12 +16,12 @@ describe('InputNumber.Cursor', () => {
changeValue: string,
cursorPos: number,
which?: number,
key?: number|string,
key?: number | string,
) {
fireEvent.focus(input)
fireEvent.keyDown(input,{which,keyCode:which,key})
fireEvent.change(input,{ target: { value: changeValue, selectionStart: 1 }})
fireEvent.keyUp(input,{which,keyCode:which,key})
fireEvent.focus(input);
fireEvent.keyDown(input, { which, keyCode: which, key });
fireEvent.change(input, { target: { value: changeValue, selectionStart: 1 } });
fireEvent.keyUp(input, { which, keyCode: which, key });
}

// https://github.com/react-component/input-number/issues/235
Expand All @@ -42,12 +41,14 @@ describe('InputNumber.Cursor', () => {
describe('pre-pend string', () => {
it('quick typing', () => {
// `$ ` => `9$ ` => `$ 9`
const { container } = render(<InputNumber defaultValue="$ " formatter={(val) => `$ ${val}`} />);
const { container } = render(
<InputNumber defaultValue="$ " formatter={(val) => `$ ${val}`} />,
);
const input = container.querySelector('input');
fireEvent.focus(input)
fireEvent.focus(input);
cursorInput(input, 0);
changeOnPos(input, '9$ ', 1, KeyCode.NUM_ONE,'1');
expect(cursorInput(input,3)).toEqual(3);
changeOnPos(input, '9$ ', 1, KeyCode.NUM_ONE, '1');
expect(cursorInput(input, 3)).toEqual(3);
});

describe('[LEGACY]', () => {
Expand All @@ -70,50 +71,55 @@ describe('InputNumber.Cursor', () => {

const { container } = render(<Demo />);
const input = container.querySelector('input');
fireEvent.focus(input)
fireEvent.focus(input);
for (let i = 0; i < prependValue.length; i += 1) {
fireEvent.keyDown(input,{which: KeyCode.ONE,keyCode: KeyCode.ONE})
fireEvent.keyDown(input, { which: KeyCode.ONE, keyCode: KeyCode.ONE });
}

const finalValue = prependValue + initValue;
cursorInput(input, prependValue.length);
fireEvent.change(input,{ target: { value: finalValue } });
fireEvent.change(input, { target: { value: finalValue } });

return input;
};

it('should fix caret position on case 1', () => {
// '$ 1'
const input = setUpCursorTest('', '1');
expect(cursorInput(input,3)).toEqual(3);
expect(cursorInput(input, 3)).toEqual(3);
});

it('should fix caret position on case 2', () => {
// '$ 111'
const input = setUpCursorTest('', '111');
expect(cursorInput(input,5)).toEqual(5);
expect(cursorInput(input, 5)).toEqual(5);
});

it('should fix caret position on case 3', () => {
// '$ 111'
const input = setUpCursorTest('1', '11');
expect(cursorInput(input,4)).toEqual(4);
expect(cursorInput(input, 4)).toEqual(4);
});

it('should fix caret position on case 4', () => {
// '$ 123,456'
const input = setUpCursorTest('456', '123');
expect(cursorInput(input,6)).toEqual(6);
expect(cursorInput(input, 6)).toEqual(6);
});
});
});

describe('append string', () => {
it('position caret before appended characters', () => {
const { container } = render(<InputNumber formatter={(value) => `${value}%`} parser={(value) => value.replace('%', '')} />);
const { container } = render(
<InputNumber
formatter={(value) => `${value}%`}
parser={(value) => value.replace('%', '')}
/>,
);
const input = container.querySelector('input');
fireEvent.focus(input);
fireEvent.change(input,{ target: { value: '5' } });
fireEvent.change(input, { target: { value: '5' } });
expect(cursorInput(input)).toEqual(1);
});
});
Expand Down
4 changes: 2 additions & 2 deletions tests/focus.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { spyElementPrototypes } from '@rc-component/util';
import { fireEvent, render } from '@testing-library/react';
import InputNumber, { InputNumberRef } from '../src';
import { spyElementPrototypes } from '@rc-component/util/lib/test/domHook';
import React from 'react';
import InputNumber, { InputNumberRef } from '../src';

const getInputRef = () => {
const ref = React.createRef<InputNumberRef>();
Expand Down
2 changes: 1 addition & 1 deletion tests/formatter.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import KeyCode from '@rc-component/util/lib/KeyCode';
import { KeyCode } from '@rc-component/util';
import React from 'react';
import InputNumber from '../src';
import { fireEvent, render } from './util/wrapper';
Expand Down
2 changes: 1 addition & 1 deletion tests/github.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import KeyCode from '@rc-component/util/lib/KeyCode';
import { KeyCode } from '@rc-component/util';
import React from 'react';
import InputNumber from '../src';
import { act, fireEvent, render, screen, waitFor } from './util/wrapper';
Expand Down
2 changes: 1 addition & 1 deletion tests/input.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import KeyCode from '@rc-component/util/lib/KeyCode';
import { KeyCode } from '@rc-component/util';
import React from 'react';
import InputNumber, { InputNumberProps, InputNumberRef } from '../src';
import { fireEvent, render } from './util/wrapper';
Expand Down
2 changes: 1 addition & 1 deletion tests/keyboard.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import KeyCode from '@rc-component/util/lib/KeyCode';
import { KeyCode } from '@rc-component/util';
import InputNumber from '../src';
import { fireEvent, render } from './util/wrapper';

Expand Down
6 changes: 3 additions & 3 deletions tests/precision.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { KeyCode } from '@rc-component/util';
import '@testing-library/jest-dom';
import { render, fireEvent } from '@testing-library/react';
import KeyCode from '@rc-component/util/lib/KeyCode';
import { fireEvent, render } from '@testing-library/react';
import React from 'react';
import InputNumber from '../src';

describe('InputNumber.Precision', () => {
Expand Down
10 changes: 6 additions & 4 deletions tests/props.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { KeyCode } from '@rc-component/util';
import '@testing-library/jest-dom';
import { render, fireEvent } from '@testing-library/react';
import KeyCode from '@rc-component/util/lib/KeyCode';
import { fireEvent, render } from '@testing-library/react';
import React from 'react';
import type { ValueType } from '../src';
import InputNumber from '../src';

Expand Down Expand Up @@ -410,7 +410,9 @@ describe('InputNumber.Props', () => {
describe('mode props', () => {
it('render spinner mode', () => {
const { container } = render(<InputNumber value={1} mode="spinner" />);
expect(container.querySelector('.rc-input-number')).toHaveClass('rc-input-number-mode-spinner');
expect(container.querySelector('.rc-input-number')).toHaveClass(
'rc-input-number-mode-spinner',
);
});
});

Expand Down
32 changes: 19 additions & 13 deletions tests/wheel.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import KeyCode from '@rc-component/util/lib/KeyCode';
import { KeyCode } from '@rc-component/util';
import InputNumber from '../src';
import { fireEvent, render } from './util/wrapper';

Expand All @@ -7,43 +7,47 @@ describe('InputNumber.Wheel', () => {
const onChange = jest.fn();
const { container } = render(<InputNumber onChange={onChange} changeOnWheel />);
fireEvent.focus(container.firstChild);
fireEvent.wheel(container.querySelector('input'), {deltaY: -1});
fireEvent.wheel(container.querySelector('input'), { deltaY: -1 });
expect(onChange).toHaveBeenCalledWith(1);
});

it('wheel up with pressing shift key', () => {
const onChange = jest.fn();
const { container } = render(<InputNumber onChange={onChange} step={0.01} value={1.2} changeOnWheel />);
const { container } = render(
<InputNumber onChange={onChange} step={0.01} value={1.2} changeOnWheel />,
);
fireEvent.focus(container.firstChild);
fireEvent.keyDown(container.querySelector('input'), {
which: KeyCode.SHIFT,
key: 'Shift',
keyCode: KeyCode.SHIFT,
shiftKey: true,
});
fireEvent.wheel(container.querySelector('input'), {deltaY: -1});
fireEvent.wheel(container.querySelector('input'), { deltaY: -1 });
expect(onChange).toHaveBeenCalledWith(1.3);
});

it('wheel down', () => {
const onChange = jest.fn();
const { container } = render(<InputNumber onChange={onChange} changeOnWheel />);
fireEvent.focus(container.firstChild);
fireEvent.wheel(container.querySelector('input'), {deltaY: 1});
fireEvent.wheel(container.querySelector('input'), { deltaY: 1 });
expect(onChange).toHaveBeenCalledWith(-1);
});

it('wheel down with pressing shift key', () => {
const onChange = jest.fn();
const { container } = render(<InputNumber onChange={onChange} step={0.01} value={1.2} changeOnWheel />);
const { container } = render(
<InputNumber onChange={onChange} step={0.01} value={1.2} changeOnWheel />,
);
fireEvent.focus(container.firstChild);
fireEvent.keyDown(container.querySelector('input'), {
which: KeyCode.SHIFT,
key: 'Shift',
keyCode: KeyCode.SHIFT,
shiftKey: true,
});
fireEvent.wheel(container.querySelector('input'), {deltaY: 1});
fireEvent.wheel(container.querySelector('input'), { deltaY: 1 });
expect(onChange).toHaveBeenCalledWith(1.1);
});

Expand All @@ -52,32 +56,34 @@ describe('InputNumber.Wheel', () => {
const { container, rerender } = render(<InputNumber onChange={onChange} />);
fireEvent.focus(container.firstChild);

fireEvent.wheel(container.querySelector('input'), {deltaY: -1});
fireEvent.wheel(container.querySelector('input'), { deltaY: -1 });
expect(onChange).not.toHaveBeenCalled();

fireEvent.wheel(container.querySelector('input'), {deltaY: 1});
fireEvent.wheel(container.querySelector('input'), { deltaY: 1 });
expect(onChange).not.toHaveBeenCalled();

rerender(<InputNumber onChange={onChange} changeOnWheel />);
fireEvent.focus(container.firstChild);

fireEvent.wheel(container.querySelector('input'), {deltaY: 1});
fireEvent.wheel(container.querySelector('input'), { deltaY: 1 });
expect(onChange).toHaveBeenCalledWith(-1);
});

it('wheel is limited to range', () => {
const onChange = jest.fn();
const { container } = render(<InputNumber onChange={onChange} min={-3} max={3} changeOnWheel />);
const { container } = render(
<InputNumber onChange={onChange} min={-3} max={3} changeOnWheel />,
);
fireEvent.focus(container.firstChild);
fireEvent.keyDown(container.querySelector('input'), {
which: KeyCode.SHIFT,
key: 'Shift',
keyCode: KeyCode.SHIFT,
shiftKey: true,
});
fireEvent.wheel(container.querySelector('input'), {deltaY: -1});
fireEvent.wheel(container.querySelector('input'), { deltaY: -1 });
expect(onChange).toHaveBeenCalledWith(3);
fireEvent.wheel(container.querySelector('input'), {deltaY: 1});
fireEvent.wheel(container.querySelector('input'), { deltaY: 1 });
expect(onChange).toHaveBeenCalledWith(-3);
});
});