Use the logging module instead of print#9
Merged
Conversation
Every module gets a logger = logging.getLogger(__name__); the 22 print() call sites become logger.info (progress: boundary-detection method announcements, pid/tid processing, call-log counts) or logger.warning (libtorch_cuda skip, missing module logs, on-the-fly disassembly, function insert/remove anomalies), with the manual "Warning:" prefixes dropped in favor of the level. logging.basicConfig lives only in the entry points (main.py:main and the postprocess __main__ block) so library consumers keep control of logging configuration. Diagnostics consequently move from stdout to stderr; the JSON/CSV artifacts are unchanged. The deliberate edition-gating message in edition.py (sys.exit) is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every module gets a logger = logging.getLogger(name); the 22 print() call sites become logger.info (progress: boundary-detection method announcements, pid/tid processing, call-log counts) or logger.warning (libtorch_cuda skip, missing module logs, on-the-fly disassembly, function insert/remove anomalies), with the manual "Warning:" prefixes dropped in favor of the level.
logging.basicConfig lives only in the entry points (main.py:main and the postprocess main block) so library consumers keep control of logging configuration. Diagnostics consequently move from stdout to stderr; the JSON/CSV artifacts are unchanged. The deliberate edition-gating message in edition.py (sys.exit) is untouched.