Test/pytest unit tests#8
Merged
Merged
Conversation
It captures no closure state and being nested made it untestable; no behavior change.
47 tests covering the pure logic that previous bugs lived in: - postprocess: remove_duplicate_branch_taken, get_pid_tid - process: deduplicate_modules (regression for the dedup bug) and get_loaded_module with a stubbed Module (multi-tid dedup, empty-file fallback to other pids, malformed-line rejection) - function_call: log-line parsers, Call.__repr__ (regression for the self.abs bug), BlockInfo parsing, and process_logs call-tree construction with stubbed process memory - library: function range lookup, is_function_start, insert (split / before-first / gap) and remove (first / middle / non-start) against a synthetic function list, no ELF fixture required The CI test job fetches only the sr-utils submodule (imported transitively by library.py); the heavy native submodules are not needed for unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.