Remove dead capstone disassembly subsystem; drop Python capstone#13
Merged
Conversation
The --filter removal left the capstone-backed disassembly path unreferenced: nothing read the instruction stream that Library.decode() produced. Remove it: - library.py: delete the Instruction class, decode()/dump()/ get_instruction_at_address(), the now-unused _list_executable_sections() helper, the _instructions/_addr_to_instruction state, and the capstone imports. - disassembler.py: deleted (only held the capstone disassemble_data wrapper). - process.py: drop the 'if mode == 0: decode()' call and the get_instruction_at_address wrapper; the 'mode' parameter is now vestigial across Module/get_loaded_module/ProcessMemory (rich/light is already carried by analyze_function_prototypes), so remove it. postprocess.py updated to match. - pyproject.toml / requirements.txt: drop the Python capstone==5.0.0.post1 dep. - build-bundles.yml: heavy-edition import check 'import angr, capstone' -> 'import angr'. - docs: update edition tables / dependency lists accordingly. libcapstone (the C library) is unaffected -- nucleus still links it, so the capstone submodule and its build steps in dev.sh/build-native.sh stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.