Replace validation asserts with real exceptions; name the ld.so ancho…#10
Merged
Conversation
…r constants assert statements vanish under python -O, so they are unreliable for validating trace logs and external tool results: - malformed module-log and block-info lines now raise ValueError (with the offending line and file in the message) - FunSeeker failure raises RuntimeError including the tool output - internal invariants in identify_false_positives and the get_potential_leading_call precondition raise RuntimeError; the predecessor-window search also gets an explicit j = -1 init, fixing a latent NameError when a node first appears at index 0 The hardcoded loader path and 0x56d5 offset in identify_false_negatives become module constants (_LDSO_PATH, _LDSO_FIXUP_CALL_OFFSET) with a comment documenting that the glibc-build coupling is deliberate: on a different ld.so build the anchor never matches and no false negatives are recovered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.