Skip to content

Add release-readiness CLI smoke tests for hotpath scan and clarify help text#16

Closed
rdzehtsiar wants to merge 1 commit into
masterfrom
codex/add-release-readiness-cli-smoke-tests
Closed

Add release-readiness CLI smoke tests for hotpath scan and clarify help text#16
rdzehtsiar wants to merge 1 commit into
masterfrom
codex/add-release-readiness-cli-smoke-tests

Conversation

@rdzehtsiar

Copy link
Copy Markdown
Owner

Motivation

  • Prevent embarrassing command-surface regressions for the first OSS release by adding a short, focused CLI smoke test suite for the core hotpath scan variants.
  • Make the --pretty and --full flag behavior explicit in the help text so users and tests can rely on stable messaging.

Description

  • Clarify the scan help docs in src/main.rs to state that --pretty requires --json and that --full forces a full rebuild by deleting the existing local index before scanning.
  • Add fixture-based release smoke tests in tests/scanner_cli.rs that assert hotpath scan --help mentions JSON/pretty/full rebuild text, that hotpath scan --json --pretty emits four-space indented JSON, that hotpath scan --pretty (without --json) fails with a helpful clap error mentioning --pretty and --json, and that hotpath scan --full --json succeeds when an index already exists and reports a "full" scan.
  • Preserve offline, fixture-driven testing patterns by using Fixture and GitFixture helpers and avoiding any network access.

Testing

  • Ran the targeted smoke tests with cargo test release_smoke --test scanner_cli, which reported all new smoke tests passing.
  • Ran formatting, lints, and full test suite with cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings, and cargo test, and all checks/tests completed successfully.

Codex Task

@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Qodana for Rust

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@rdzehtsiar rdzehtsiar closed this Jun 20, 2026
@rdzehtsiar rdzehtsiar deleted the codex/add-release-readiness-cli-smoke-tests branch June 20, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants