Add release-readiness CLI smoke tests for hotpath scan and clarify help text#16
Closed
rdzehtsiar wants to merge 1 commit into
Closed
Add release-readiness CLI smoke tests for hotpath scan and clarify help text#16rdzehtsiar wants to merge 1 commit into
hotpath scan and clarify help text#16rdzehtsiar wants to merge 1 commit into
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Qodana for RustIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
hotpath scanvariants.--prettyand--fullflag behavior explicit in the help text so users and tests can rely on stable messaging.Description
scanhelp docs insrc/main.rsto state that--prettyrequires--jsonand that--fullforces a full rebuild by deleting the existing local index before scanning.tests/scanner_cli.rsthat asserthotpath scan --helpmentions JSON/pretty/full rebuild text, thathotpath scan --json --prettyemits four-space indented JSON, thathotpath scan --pretty(without--json) fails with a helpful clap error mentioning--prettyand--json, and thathotpath scan --full --jsonsucceeds when an index already exists and reports a"full"scan.FixtureandGitFixturehelpers and avoiding any network access.Testing
cargo test release_smoke --test scanner_cli, which reported all new smoke tests passing.cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings, andcargo test, and all checks/tests completed successfully.Codex Task