Skip to content

Clarify no-Go scan assessment messaging#12

Closed
rdzehtsiar wants to merge 1 commit into
masterfrom
codex/improve-first-run-messaging-for-non-go-repos
Closed

Clarify no-Go scan assessment messaging#12
rdzehtsiar wants to merge 1 commit into
masterfrom
codex/improve-first-run-messaging-for-non-go-repos

Conversation

@rdzehtsiar

Copy link
Copy Markdown
Owner

Motivation

  • The terminal first-run message for non-Go repositories was blunt (No production Go files were scored.) and could be interpreted as a broken scan instead of a scoped limitation of the Go-only scoring model.
  • Make the terminal Assessment section clearly state that file scanning completed but repository-level risk scoring is unavailable because the current scoring model is Go-only.

Description

  • Update the terminal assessment renderer in src/pipeline/scan_summary.rs so (false, "none", _) returns the explanatory message: Files were scanned, but no production Go files were available for the current Go-only scoring model.
  • Strengthen the renderer unit test in src/pipeline/scan_summary.rs to assert the new reason and to assert the old blunt message is not present.
  • Update the CLI integration test tests/scanner_cli.rs::scan_summary_reports_no_go_coverage_and_limitation to assert the Assessment block includes Scoring confidence: none and the new Reason wording while continuing to verify the unavailable risk state.
  • Keep JSON output schema/format unchanged and intentionally made no changes to the JSON reason generation so machine-readable output remains compatible.

Testing

  • Ran cargo fmt --check and it succeeded.
  • Ran cargo clippy --all-targets --all-features -- -D warnings and it succeeded with no warnings.
  • Ran focused tests cargo test scan_summary_reports_no_go_coverage_and_limitation and cargo test renders_stable_fallbacks_without_hotspots_or_project and both passed.
  • Ran the full test suite with cargo test and all tests passed (129 unit tests + CLI tests shown as passing).

Codex Task

@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Qodana for Rust

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@rdzehtsiar rdzehtsiar closed this Jun 20, 2026
@rdzehtsiar rdzehtsiar deleted the codex/improve-first-run-messaging-for-non-go-repos branch June 20, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants