Fix Unicode progress bar literals#11
Closed
rdzehtsiar wants to merge 1 commit into
Closed
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Qodana for RustIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NO_COLOR,dumbterminals, and non-UTF-8 Windows console output.Description
UNICODE_PROGRESS_BOUNDARYandUNICODE_PROGRESS_FILLconstants and use them inrender_progress_bar_with_styleto centralize the Unicode glyphs.[{}{}]with#fills) so fallback behavior is preserved.src/pipeline/reporter.rsto assert correct UTF-8 strings like│████ │and the ASCII fallback string[#### ].Testing
cargo fmt --checkand it succeeded.cargo test reporterand the reporter unit tests passed.cargo testand all tests passed.Codex Task