Add compact "Scan" section to human scan output#10
Closed
rdzehtsiar wants to merge 1 commit into
Closed
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Qodana for RustIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
--json.Description
render_scanfunction that formats a compactScansection withType,Files: <analyzed>/<detected> analyzed,Git history,Commits: <processed>/<total|unknown>, andDuration: <duration_ms> ms.Scansection into the human output immediately after theRisksection by extendingrender_scan_summarywithrender_scan(&run.scan).src/pipeline/scan_summary.rsand integration tests intests/scanner_cli.rsto assert presence of the newScansection for both Git and non-Git runs and to keep asserting that raw JSON-style keys (e.g.,files_detected,files_analyzed,git_history) are not accidentally printed in human output.Testing
cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings, and the full test suite withcargo test; all tests passed.src/pipeline/scan_summary.rsto validaterender_scanoutput, and integration tests intests/scanner_cli.rsto cover both Git and non-Git scan summaries; they succeeded.Codex Task