LLAMA-18353: device is muting during reboot - #83
Draft
jthomp007c wants to merge 1 commit into
Draft
Conversation
DO NOT MERGE. Simply adding some debug to confirm the timing of the VSDK config, open, route_update, and mute check actions. It looks like ctrlm can check mute before route_update is finished in which case it defaults to muted
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds temporary debug logging to help confirm timing/order between VSDK config/open, route updates, and privacy/mute checks during reboot (LLAMA-18353 investigation).
Changes:
- Log “start/done” markers in
xrsr_open,xrsr_route, and privacy-mode get flow. - Add logs around
xrsr_msg_route_updatehandling and privacy-mode result reporting.
Suppressed comments (1)
src/xr-speech-router/xrsr.c:451
- The 'start' log is emitted before an early-return path (
already open), which can make traces confusing (a 'start' without a corresponding 'done'). Consider moving the start log after the early-return guard(s), or adding a matching log on the early-return path so timing traces remain interpretable.
XLOGD_INFO("LLAMA-18353 start....");
if(g_xrsr.opened) {
XLOGD_ERROR("already open");
return(false);
}
|
|
||
| bool xrsr_open(const char *host_name, const xrsr_route_t routes[], const xrsr_keyword_config_t *keyword_config, const xrsr_capture_config_t *capture_config, xrsr_power_mode_t power_mode, bool privacy_mode, bool mask_pii, json_t *json_obj_vsdk) { | ||
| json_t *json_obj_xraudio = NULL; | ||
| XLOGD_INFO("LLAMA-18353 start...."); |
| } | ||
|
|
||
| g_xrsr.opened = true; | ||
| XLOGD_INFO("LLAMA-18353 done..."); |
| } | ||
|
|
||
| bool xrsr_route(const xrsr_route_t routes[]) { | ||
| XLOGD_INFO("LLAMA-18353 start...."); |
| sem_wait(&semaphore); | ||
| sem_destroy(&semaphore); | ||
|
|
||
| XLOGD_INFO("LLAMA-18353 done..."); |
| void xrsr_msg_route_update(const xrsr_thread_params_t *params, xrsr_thread_state_t *state, void *msg) { | ||
| xrsr_queue_msg_route_update_t *route_update = (xrsr_queue_msg_route_update_t *)msg; | ||
| xrsr_src_t srcs[XRSR_SRC_INVALID+1]; | ||
| XLOGD_INFO("LLAMA-18353 start..."); |
| sem_wait(&semaphore); | ||
| sem_destroy(&semaphore); | ||
|
|
||
| XLOGD_INFO("LLAMA-18353 done..."); |
| return(false); | ||
| } | ||
|
|
||
| XLOGD_INFO("LLAMA-18353 start..."); |
| g_xrsr.privacy_mode = *enabled; | ||
| } | ||
|
|
||
| XLOGD_INFO("LLAMA-18353 done..."); |
| void xrsr_msg_route_update(const xrsr_thread_params_t *params, xrsr_thread_state_t *state, void *msg) { | ||
| xrsr_queue_msg_route_update_t *route_update = (xrsr_queue_msg_route_update_t *)msg; | ||
| xrsr_src_t srcs[XRSR_SRC_INVALID+1]; | ||
| XLOGD_INFO("LLAMA-18353 start..."); |
| if(route_update->semaphore != NULL) { | ||
| sem_post(route_update->semaphore); | ||
| } | ||
| XLOGD_INFO("LLAMA-18353 done..."); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Simply adding some debug to confirm the timing of the VSDK config, open, route_update, and mute check actions. It looks like ctrlm can check mute before route_update is finished in which case it defaults to muted