RDKEMW-16902 : xr-voice-sdk MFV plugin headers - #59
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new public header defining the Mid-Field Voice (MFV) plugin interface for the xr-voice-sdk audio stack, including capability flags, message payloads, session configuration/statistics, and the plugin API vtable.
Changes:
- Introduces
xraudio_mfv.hdefining MFV capability flags, result/error/message enums, and message/session structs. - Defines MFV plugin function pointer typedefs and
xraudio_mfv_plugin_api_tinterface exposed viaxraudio_mfv_plugin_api_get().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// @brief MFV session configuration | ||
| /// @details Specifies which optional processing features should be enabled for an MFV session. | ||
| typedef struct { | ||
| bool apply_gain; ///< true if gain should be applied to the input audio stream, false otherwise |
There was a problem hiding this comment.
Where is the gain value to be applied specified?
There was a problem hiding this comment.
If the plugin has the XRAUDIO_MFV_CAPS_AUDIO_GAIN capability set, then the plugin will determine the appropriate gain and apply it based on this flag as requested by the MW. It may be worthwhile to add an additional parameter to specify the target signal level such as -6 dBFS or whatever based on the destination's requirements.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pstick999
left a comment
pstick999
left a comment
There was a problem hiding this comment.
Approved based on design presented on 4/2/26.
| /// @param[in] object The MFV object handle | ||
| /// @param[in] info Pointer to a structure with the keyword detection details | ||
| /// @return XRAUDIO_MFV_RESULT_SUCCESS on success, or an error code on failure | ||
| typedef xraudio_mfv_result_t (*xraudio_mfv_func_session_info_t)(xraudio_mfv_object_t object, const xraudio_mfv_keyword_info_t *info); |
There was a problem hiding this comment.
What is the expected period of time from the session open API to the session info API?
No description provided.