RDKB-64798: Disable AutoExcludedURL override when Direct CDN is enabled - #36
Merged
Merged
Conversation
Reason for change: Prevent AutoExcludedURL from overriding the firmware URL when Direct CDN is enabled. Test Procedure: As mentioned in the ticket Priority: P1 Signed-off-by: plaksh175_comcast <PiramanayagamMoneka_Lakshmi@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR prevents AutoExcludedURL (RFC override) from overriding the firmware download URL when Direct CDN is enabled, aligning the override behavior with the intended Direct CDN flow.
Changes:
- Gate
AutoExcludedURLoverride ondirect_CDN != truein both XB6 and CBR firmware download scripts. - Add logging in the XB6 script when the override is skipped due to Direct CDN.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/xb6_firmwareDwnld.sh | Skips AutoExcludedURL override when Direct CDN is enabled; adds log entry when skipped. |
| scripts/cbr_firmwareDwnld.sh | Extends the existing AutoExcludedURL override condition to also require Direct CDN to be disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SanthoshGujulvajagadeesh
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Prevent AutoExcludedURL from overriding the firmware URL when Direct CDN is enabled.
Test Procedure: As mentioned in the ticket
Risks: Low
Priority: P1
Signed-off-by: plaksh175_comcast PiramanayagamMoneka_Lakshmi@comcast.com