RDKB-64798: Default xconf URL using AutoExcluded.XconfUrl dmcli param… - #29
Closed
MonekaLakshmi wants to merge 2 commits into
Closed
RDKB-64798: Default xconf URL using AutoExcluded.XconfUrl dmcli param…#29MonekaLakshmi wants to merge 2 commits into
MonekaLakshmi wants to merge 2 commits into
Conversation
… value Reason for change: Testing purpose Signed-off-by: plaksh175_comcast <PiramanayagamMoneka_Lakshmi@comcast.com>
There was a problem hiding this comment.
Pull request overview
Updates the XB6 firmware download script’s URL-override behavior to avoid forcing CDL_SERVER_OVERRIDE when Direct CDN flow is enabled, primarily for testing scenarios.
Changes:
- Adds conditional logic to set
CDL_SERVER_OVERRIDEonly whendirect_CDNis disabled for the AutoExcluded URL override path. - Adds log lines to record whether
CDL_SERVER_OVERRIDEwas set based on Direct CDN state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1331
to
+1336
| if [ "$direct_CDN" = "false" ]; then | ||
| CDL_SERVER_OVERRIDE=1 | ||
| echo "XCONF SCRIPT : Direct CDN NOT ENABLED. CDL_SERVER_OVERRIDE is set URL=$url" >> $XCONF_LOG_FILE | ||
| else | ||
| echo "XCONF SCRIPT : Direct CDN enabled. Not setting CDL_SERVER_OVERRIDE for AutoExcludedURL URL=$url" >> $XCONF_LOG_FILE | ||
| fi |
Comment on lines
+1326
to
+1331
| @@ -1327,7 +1327,13 @@ if [ "$type" != "PROD" ] && [ "$type" != "prod" ]; then | |||
| if [ "$url_override" ] ; then | |||
| url=$url_override | |||
| xconf_url=$url | |||
| CDL_SERVER_OVERRIDE=1 | |||
| # Set CDL_SERVER_OVERRIDE only for non-direct-CDN flow | |||
| if [ "$direct_CDN" = "false" ]; then | |||
Comment on lines
1326
to
1330
| url_override=`syscfg get AutoExcludedURL` | ||
| if [ "$url_override" ] ; then | ||
| # Set CDL_SERVER_OVERRIDE only for non-direct-CDN flow | ||
| if [ "$url_override" ] && [ "$direct_CDN" = "false" ]; then | ||
| url=$url_override | ||
| xconf_url=$url |
Comment on lines
1326
to
+1328
| url_override=`syscfg get AutoExcludedURL` | ||
| if [ "$url_override" ] ; then | ||
| # Set CDL_SERVER_OVERRIDE only for non-direct-CDN flow | ||
| if [ "$url_override" ] && [ "$direct_CDN" = "false" ]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… value
Reason for change: Testing purpose