fix: XB10-2960 — 5GHz 160MHz channel bandwidth always disabled on page load - #81
Open
udaybhadauria wants to merge 1 commit into
Open
Conversation
The .trigger(change) call was unconditionally firing the DFS_boot_disabled onChange handler on every page load. Since #DFS_boot_disabled is HTML default-checked (Disable), this always called .prop(disabled,true) on #channel_bandwidth3 (160MHz option), overriding the correct $dfsBoot backend-driven initialization. Fix: remove .trigger(change); the $dfsBoot static check above already handles initial page-load state from backend correctly. Ref: XB10-2960
|
📋 PR Format Reminder
Expected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 20/40/80/160 channel bandwidth radio button (
#channel_bandwidth3) in the 5GHz wireless config page is permanently disabled on every page load, regardless of backend DFS state. All other options (20 / 20/40 / 20/40/80) work correctly.Affected Build
CGM601TCOM_DEV_26Q3_sprint_20260728232920sdy_NG(SPIN 12)source/Styles/xb3/jst/wireless_network_configuration_onestack.jstRoot Cause
.trigger("change")unconditionally invokes the onChange handler at page load.Since
#DFS_boot_disabledis HTML-default-checked (Disable), this always calls.prop("disabled", true)on#channel_bandwidth3, overriding the correct$dfsBootbackend-driven init block above it.Introduced by: PR #37 —
RDKB-63519, RDKB-63615: 6GHz & XB10 models support in BWG GUICommit:
7b48cbac07| Merged: 2026-02-26 | Author: Pavan Kumar Reddy BFix
Remove
.trigger("change"). The$dfsBoot='<?% echo($dfsAtBootup); ?>'check immediately above already correctly sets initial disabled state from backend data — no trigger needed.Impact
#channel_bandwidth3(160MHz) affectedTest
Fixes: XB10-2960