RDKB-66188: add CSRF token initialization in parental reports ajaxDo() - #79
Merged
Merged
Conversation
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CSRF token initialization for the parental reports AJAX request so the existing headers: { csrfp_token: token } code sends a valid token.
Changes:
- Initialize
tokenfrom$_SESSION['Csrf_token']insideajaxDo()before issuing the AJAX request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
source/Styles/xb3/jst/parental_reports.jst:304
- The CSRF token is only sent as a request header, but the in-repo CSRFProtector implementation validates GET requests using
$_GET[csrfp_token](and its POST helper only checks$_POST, not headers). If this endpoint is protected for GET, the header alone won’t satisfy validation; include the token in the query params (or switch this endpoint to POST to avoid putting tokens in URLs).
ajaxrequest=$.ajax({
type:"GET",
url:"actionHandler/ajax_parental_reports.jst",
data:{mode:mode,timef:timef},
dataType:"json",
headers: { csrfp_token: token },
success:function(results){
udaybhadauria
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.