Revert "RDKB-65187 - WAN Manager - Telemetry for Ignite." - #221
Merged
Conversation
This reverts commit 6751e16.
guto86
approved these changes
Jul 24, 2026
S-Parthiban-Selvaraj
approved these changes
Jul 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced WAN outage-duration telemetry (Ignite) by removing the failure-timer initialization and the associated timer/marker logic from the TR-181 RDK bus layer.
Changes:
- Removes
WanMgr_FailureTimer_Init()call from process startup. - Deletes the WAN failure timer state machine and
WAN_DOWN_DURATIONmarker emission logic. - Cleans up related header declarations and includes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/WanManager/wanmgr_main.c | Removes startup call that initialized the WAN failure timer. |
| source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.h | Drops the WanMgr_FailureTimer_Init() prototype as part of the revert. |
| source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c | Removes failure-timer implementation and related logic inside Update_Interface_Status(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c:42
- This file still uses
struct timespec/clock_gettime(e.g., in telemetry code), but the direct#include <time.h>was removed. It currently compiles only because<time.h>is pulled in transitively via another project header; please include<time.h>here to keep the translation unit self-contained and avoid future breakage if headers change.
#include "wanmgr_rdkbus_apis.h"
#include "dmsb_tr181_psm_definitions.h"
#include "wanmgr_net_utils.h"
#include "wanmgr_interface_sm.h"
#ifdef RBUS_BUILD_FLAG_ENABLE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #213. Since product wants to hold this change.