Skip to content

Revert "RDKB-65187 - WAN Manager - Telemetry for Ignite." - #221

Merged
guto86 merged 2 commits into
mainfrom
revert-213-RDKB-65029-Test
Jul 24, 2026
Merged

Revert "RDKB-65187 - WAN Manager - Telemetry for Ignite."#221
guto86 merged 2 commits into
mainfrom
revert-213-RDKB-65029-Test

Conversation

@LakshminarayananShenbagaraj

Copy link
Copy Markdown
Contributor

Reverts #213. Since product wants to hold this change.

Copilot AI review requested due to automatic review settings July 24, 2026 13:53
@LakshminarayananShenbagaraj
LakshminarayananShenbagaraj requested a review from a team as a code owner July 24, 2026 13:53
@LakshminarayananShenbagaraj LakshminarayananShenbagaraj added the enhancement New feature or request label Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previously introduced WAN outage-duration telemetry (Ignite) by removing the failure-timer initialization and the associated timer/marker logic from the TR-181 RDK bus layer.

Changes:

  • Removes WanMgr_FailureTimer_Init() call from process startup.
  • Deletes the WAN failure timer state machine and WAN_DOWN_DURATION marker emission logic.
  • Cleans up related header declarations and includes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
source/WanManager/wanmgr_main.c Removes startup call that initialized the WAN failure timer.
source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.h Drops the WanMgr_FailureTimer_Init() prototype as part of the revert.
source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Removes failure-timer implementation and related logic inside Update_Interface_Status().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c
Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c
Copilot AI review requested due to automatic review settings July 24, 2026 14:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c:42

  • This file still uses struct timespec/clock_gettime (e.g., in telemetry code), but the direct #include <time.h> was removed. It currently compiles only because <time.h> is pulled in transitively via another project header; please include <time.h> here to keep the translation unit self-contained and avoid future breakage if headers change.
#include "wanmgr_rdkbus_apis.h"
#include "dmsb_tr181_psm_definitions.h"
#include "wanmgr_net_utils.h"
#include "wanmgr_interface_sm.h"
#ifdef RBUS_BUILD_FLAG_ENABLE

@guto86
guto86 merged commit 392dc24 into main Jul 24, 2026
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
@LakshminarayananShenbagaraj
LakshminarayananShenbagaraj deleted the revert-213-RDKB-65029-Test branch July 24, 2026 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants