Merge #87
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: "CLA" | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| actions: write | ||
| statuses: write | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_target: | ||
| types: [opened, closed, synchronize] | ||
|
|
||
| jobs: | ||
| CLA-Lite: | ||
| name: "Signature" | ||
| uses: rdkcentral/cmf-actions/.github/workflows/cla.yml@v1 | ||
| secrets: | ||
| PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ASSISTANT }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Code Coverage | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| execute-unit-code-coverage-report-on-release: | ||
| name: Test coverage report for release | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Run unit tests with coverage flags enabled | ||
| run: | | ||
| sh run_ut.sh --enable-cov | ||
| - name: Caculate the code coverage summary | ||
| run: | | ||
| lcov --list tr69hostif_coverage.info | grep "Lines\|Total" > /tmp/coverage_summary.txt | ||
| cd - | ||
|
|
||
| - name: Update the coverage report to Pull request using actions | ||
| uses: actions/github-script@v4 | ||
| with: | ||
| script: | | ||
| const fs = require('fs'); | ||
| const lcov_result = fs.readFileSync('/tmp/coverage_summary.txt', 'utf8'); | ||
|
|
||
| github.issues.createComment({ | ||
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: | ||
| '## Code Coverage Summary \n' + | ||
| ' ' + | ||
| '```' + | ||
| lcov_result + | ||
| '```' | ||
| }); | ||
| - name: Generate the html report | ||
| run: | | ||
| genhtml tr69hostif_coverage.info --output-directory /tmp/coverage_report | ||
| cd - | ||
| - name: Upload the coverage report to Pull request using actions | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage-report | ||
| path: /tmp/coverage_report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| ########################################################################## | ||
| # If not stated otherwise in this file or this component's LICENSE | ||
| # file the following copyright and licenses apply: | ||
| # | ||
| # Copyright 2024 RDK Management | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
|
Check failure on line 7 in dependent_rdk_pkg_installer.sh
|
||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| ########################################################################## | ||
|
|
||
| # Clone and build rbus | ||
| export RBUS_ROOT=/usr | ||
| export RBUS_INSTALL_DIR=${RBUS_ROOT}/local | ||
| mkdir -p $RBUS_INSTALL_DIR | ||
| cd $RBUS_ROOT | ||
|
|
||
|
|
||
| WORKDIR=/opt/WORKDIR | ||
| mkdir -p $WORKDIR | ||
|
|
||
| cd $WORKDIR | ||
| git clone https://github.com/xmidt-org/trower-base64.git | ||
| cd trower-base64 | ||
| meson setup build | ||
| ninja -C build | ||
| ninja -C build install | ||
| cd $WORKDIR | ||
| rm -rf trower-base64 | ||
|
|
||
| # cJson flavor used in RDK stack | ||
| cd $WORKDIR | ||
| git clone https://github.com/DaveGamble/cJSON.git | ||
| cd cJSON | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| make && make install | ||
| cd $WORKDIR | ||
| rm -rf cJSON | ||
|
|
||
| # Include WDMP package | ||
| cd $WORKDIR | ||
| git clone https://github.com/xmidt-org/wdmp-c.git | ||
| cd wdmp-c | ||
| sed -i '/WDMP_ERR_SESSION_IN_PROGRESS/a\ WDMP_ERR_INTERNAL_ERROR,\n WDMP_ERR_DEFAULT_VALUE,' src/wdmp-c.h | ||
| cmake -H. -Bbuild -DBUILD_FOR_DESKTOP=ON -DCMAKE_BUILD_TYPE=Debug | ||
| make -C build && make -C build install | ||
| cd $WORKDIR | ||
| rm -rf wdmp-c | ||
|
|
||
| # Install dependencies of libparodus | ||
| cd $WORKDIR | ||
| git clone https://github.com/nanomsg/nanomsg.git | ||
| cd nanomsg | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| cmake --build . | ||
| cmake --build . --target install | ||
| cd $WORKDIR | ||
| rm -rf nanomsg | ||
|
|
||
| git clone https://github.com/xmidt-org/cimplog.git | ||
| cd cimplog | ||
| git checkout 8a5fb3c2f182241d17f5342bea5b7688c28cd1fd | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| make && make install | ||
| cd $WORKDIR | ||
| rm -rf cimplog | ||
|
|
||
|
|
||
| cd $WORKDIR | ||
| git clone https://github.com/xmidt-org/wrp-c.git | ||
| cd wrp-c | ||
| git checkout 9587e8db33dbbfcd9b78ef66cc2eaf16dfb9afcf | ||
| # replace 7a98138f27f27290e680bf8fbf1f8d1b089bf138 with 445880108a1d171f755ff6ac77e03fbebbb23729 in CMakeLists.txt | ||
| # Message pack revision used in libparadous is not buildable with latest gcc versions | ||
| sed -i 's/7a98138f27f27290e680bf8fbf1f8d1b089bf138/445880108a1d171f755ff6ac77e03fbebbb23729/g' CMakeLists.txt | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| make && make install | ||
| cd $WORKDIR | ||
| rm -rf wrp-c | ||
|
|
||
| cd $WORKDIR | ||
| git clone https://github.com/xmidt-org/libparodus.git | ||
| cd libparodus | ||
| # replace 7a98138f27f27290e680bf8fbf1f8d1b089bf138 with 445880108a1d171f755ff6ac77e03fbebbb23729 in CMakeLists.txt | ||
| # Message pack revision used in libparadous is not buildable with latest gcc versions | ||
| sed -i 's/7a98138f27f27290e680bf8fbf1f8d1b089bf138/445880108a1d171f755ff6ac77e03fbebbb23729/g' CMakeLists.txt | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| make && make install | ||
| cd $WORKDIR | ||
| rm -rf libparodus | ||
|
|
||
|
|
||
| #rtrouted -f -l DEBUG | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
dependent_rdk_pkg_installer.shscript clones and builds several third-party projects (e.g.trower-base64,cJSON,wdmp-c,nanomsg) directly from mutable GitHub branches/tags without pinning to immutable commits or verifying integrity, then installs them into the build/runtime environment. If any of these upstream repositories are compromised or force-pushed, an attacker could inject malicious code that is built and executed in your CI or developer environments, potentially compromising build artifacts or secrets. To mitigate this supply-chain risk, pin eachgit cloneto a specific trusted commit or release tag and, where possible, add checksum/signature verification before building and installing.