RDKEMW-19406: tr69hostif migrated to thunder - #525
Open
santoshcomcast wants to merge 1 commit into
Open
Conversation
Reason for change: tr69hostif migrated to thunder Test Procedure: refer RDKEMW-19406 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the tr69hostif STBService migration to Thunder by aligning the C++ “DisplayInfo.1.connected” handling with Thunder’s property-style scalar boolean responses and extending the Thunder mock server to cover additional STBService Thunder APIs used by L2/functional tests.
Changes:
- Extend the native-platform Thunder JSON-RPC mock server with additional STBService API responses (DisplaySettings/DisplayInfo/PowerManager/AVOutput/HdcpProfile/Capabilities).
- Update STBService VideoOutput and DisplayDevice “Status” getters to parse
DisplayInfo.1.connectedas a scalar boolean Thunder result. - Update the copyright year in
Capabilities_Thunder.cpp.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test-artifacts/native-platform/thunder-mock-server.js | Adds mock responses for additional STBService Thunder methods/properties used by L2 tests. |
| src/hostif/profiles/STBService/Components_VideoOutput_Thunder.cpp | Switches DisplayInfo connected parsing to scalar-bool result extraction. |
| src/hostif/profiles/STBService/Components_DisplayDevice_Thunder.cpp | Switches DisplayInfo connected parsing to scalar-bool result extraction. |
| src/hostif/profiles/STBService/Capabilities_Thunder.cpp | Updates copyright header year. |
Comment on lines
+267
to
+273
| result: { | ||
| videocodecinfo: [{ | ||
| codec: 'H.265', | ||
| profile: 'Main', | ||
| level: '5.1' | ||
| }] | ||
| }, |
Code Coverage Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: tr69hostif migrated to thunder
Test Procedure: refer RDKEMW-19406
Risks: High
Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com