sync to develop by santoshcomcast · Pull Request #516 · rdkcentral/tr69hostif

santoshcomcast · 2026-07-23T13:11:01Z

No description provided.

* Refactor Docker exec command in L2-tests.yml * Update L2-tests.yml --------- Co-authored-by: nhanasi <navihansi@gmail.com>

Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>

* RDKEMW-20790 : Improve L2 Coverage for tr69hostif * RDKEMW-20790 : L2 Coverage for tr69hostif update --------- Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com> Co-authored-by: madhubabutt <114217841+madhubabutt@users.noreply.github.com> Co-authored-by: Hanasi <nhanas001c@cable.comcast.com>

* Update data-model-generic.xml * Update data-model-generic.xml * Update Device_DeviceInfo.cpp * Update Device_DeviceInfo.h * Potential fix for pull request finding 'CodeQL / File created without restricting permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Update data-model-generic.xml --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Tr69hostif release for Develop OTEL feature

github-advanced-security · 2026-07-23T13:11:02Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot

Pull request overview

This PR syncs with develop by expanding the L2 functional test suite (pytest + feature specs) across multiple TR-181 areas and by adding a new RFC parameter to enable/disable distributed tracing (OTEL) via a flag file + systemd service control.

Changes:

Added multiple new L2 pytest modules + corresponding .feature specs (Bluetooth, DeviceInfo extended, StorageService, InterfaceStack, xOpsDeviceMgmt RPC/Logging).
Expanded existing L2 coverage for IP/Ethernet/MoCA/DeviceTime/ProcessStatus/WebPA and updated coverage documentation + runner wiring.
Introduced Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.DistributedTracing.Enable into the data model and implemented its SET handling in Device_DeviceInfo.

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/functional-tests/tests/tr69hostif_webpa_rdkdlmgr.py	Adds WebPA server/token URL GET tests.
test/functional-tests/tests/tr69hostif_storageservice.py	New StorageService RBUS GET coverage.
test/functional-tests/tests/tr69hostif_rfc_store_params.py	Renames RFC tests to reflect SET handlers.
test/functional-tests/tests/tr69hostif_processor_processstatus.py	Reorders tests and adds ProcessStatus CPUUsage GET.
test/functional-tests/tests/tr69hostif_opsdevicemgmt_rpc.py	New xOpsDeviceMgmt RPC RBUS GET/SET coverage.
test/functional-tests/tests/tr69hostif_opsdevicemgmt_logging.py	New xOpsDeviceMgmt Logging RBUS GET/SET coverage.
test/functional-tests/tests/tr69hostif_moca.py	Adds additional MoCA interface GET/SET negative coverage.
test/functional-tests/tests/tr69hostif_ipremotesupport.py	Reorders IPRemoteSupport tests.
test/functional-tests/tests/tr69hostif_ip.py	Adds many IP interface/address/stats SET/GET tests and reorders execution.
test/functional-tests/tests/tr69hostif_interfacestack.py	New InterfaceStack RBUS GET coverage.
test/functional-tests/tests/tr69hostif_ethernet_handlers.py	Adds Ethernet SET coverage and expands negative GET/SET checks.
test/functional-tests/tests/tr69hostif_devicetime.py	Adds Device.Time SET negative coverage and Enable checks.
test/functional-tests/tests/tr69hostif_device_info.py	New extended DeviceInfo coverage (incl. AppArmor blocklist + MemInsight + reboot stop).
test/functional-tests/tests/tr69hostif_custom.py	Adds more custom alias-related coverage.
test/functional-tests/tests/tr69hostif_bluetooth.py	New Bluetooth xBlueTooth parameter coverage.
test/functional-tests/tests/basic_constants.py	Adds Bluetooth constants used by Bluetooth tests.
test/functional-tests/features/tr69hostif_webpa_rdkdlmgr.feature	Adds scenarios for WebPA Server/TokenServer URL GET.
test/functional-tests/features/tr69hostif_storageservice.feature	New StorageService feature spec.
test/functional-tests/features/tr69hostif_processor_processstatus.feature	Adds CPUUsage scenario requirements.
test/functional-tests/features/tr69hostif_opsdevicemgmt_rpc.feature	New xOpsDeviceMgmt RPC feature spec.
test/functional-tests/features/tr69hostif_opsdevicemgmt_logging.feature	New xOpsDeviceMgmt Logging feature spec.
test/functional-tests/features/tr69hostif_moca.feature	Adds MoCA KeyPassphrase/PowerLimit scenarios.
test/functional-tests/features/tr69hostif_ip.feature	Expands IP scenarios to include SET/negative expectations.
test/functional-tests/features/tr69hostif_interfacestack.feature	New InterfaceStack feature spec.
test/functional-tests/features/tr69hostif_ethernet_handlers.feature	Expands Ethernet scenarios to include SET/negative expectations.
test/functional-tests/features/tr69hostif_devicetime.feature	Adds Device.Time SET negative scenarios and Enable checks.
test/functional-tests/features/tr69hostif_device_info.feature	New extended DeviceInfo feature spec.
test/functional-tests/features/tr69hostif_custom.feature	Updates custom scenarios and adds alias-related checks.
test/functional-tests/features/tr69hostif_bluetooth.feature	New Bluetooth feature spec.
test/docs/L2_Test_Coverage.md	Updates L2 coverage metrics, file lists, and gap analysis status.
src/hostif/profiles/DeviceInfo/Device_DeviceInfo.h	Adds DistributedTracing RFC parameter + handler declaration.
src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp	Implements SET handling for DistributedTracing RFC (flag file + systemctl).
src/hostif/parodusClient/waldb/data-model/data-model-generic.xml	Adds DistributedTracing.Enable to the TR-181 data model.
run_l2.sh	Extends L2 runner to execute new pytest modules and adds loguploadstatus seed file.
CHANGELOG.md	Adds 1.4.9 section and updates 1.4.8 metadata.
.github/workflows/L2-tests.yml	Adjusts CI container invocation + result upload working directory.

Comments suppressed due to low confidence (5)

test/functional-tests/tests/tr69hostif_webpa_rdkdlmgr.py:106

The new WebPA TokenServer URL GET test asserts an RBUS exception, but the feature spec added in this PR expects the GET to succeed (no error).
test/functional-tests/tests/tr69hostif_storageservice.py:47
This PhysicalMedium.Name test currently expects an RBUS exception, but the feature spec added in this PR marks it as implemented (GET should not contain an error).
test/functional-tests/tests/tr69hostif_storageservice.py:110
This SMARTCapable test currently expects an RBUS exception, but the feature spec added in this PR marks it as implemented (GET should not contain an error).
test/functional-tests/tests/tr69hostif_storageservice.py:117
This Health test currently expects an RBUS exception, but the feature spec added in this PR marks it as implemented (GET should not contain an error).
test/functional-tests/tests/tr69hostif_storageservice.py:132
This PhysicalMediumNumberOfEntries test currently expects an RBUS exception, but the feature spec added in this PR expects this GET to succeed (no error).

+def test_X_RDK_WebPA_Server_URL_Get_Handler():
+    DATA_ELEMENT_NAME = "Device.X_RDK_WebPA_Server.URL"
+    rstdout = rbus_get_data(DATA_ELEMENT_NAME)
+    assert RBUS_EXCEPTION_STRING in rstdout


+def test_StorageService_ClientNumberOfEntries_Get_Handler():
+    DATA_ELEMENT_NAME = "Device.Services.StorageServiceNumberOfEntries"
+    rstdout = rbus_get_data(DATA_ELEMENT_NAME)
+    assert RBUS_EXCEPTION_STRING in rstdout


+def test_ProcessStatus_CPUUsage_Get_Handler():
+    #clear_tr69hostiflogs()
+    DATA_ELEMENT_NAME = "Device.DeviceInfo.ProcessStatus.CPUUsage"
+    # Force reload config fetch from xconf
+    rstdout = rbus_get_data(DATA_ELEMENT_NAME)
+    assert RBUS_EXCEPTION_STRING not in rstdout
+


+        /* Create flag file watched by librdk_otlp.so via inotify in all processes */
+        int fd = open(RDK_TRACING_FLAG_FILE, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
+        if (fd >= 0)
+        {
+            FILE *fp = fdopen(fd, "w");
+            if (fp)
+            {
+                fclose(fp);
+                RDK_LOG(RDK_LOG_INFO, LOG_TR69HOSTIF,
+                        "[%s] Created tracing flag file %s\n", __FUNCTION__, RDK_TRACING_FLAG_FILE);
+            }
+            else
+            {
+                close(fd);
+                RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF,
+                        "[%s] Failed to create tracing flag file %s: %s\n",
+                        __FUNCTION__, RDK_TRACING_FLAG_FILE, strerror(errno));
+            }
+        }
+        else
+        {
+            RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF,
+                    "[%s] Failed to create tracing flag file %s: %s\n",
+                    __FUNCTION__, RDK_TRACING_FLAG_FILE, strerror(errno));
+        }


Abhinavpv28 and others added 7 commits July 15, 2026 12:31

RDKEMW-21374: Fix L2 Upload Results to Automatics Error (#508)

f3c5a41

* Refactor Docker exec command in L2-tests.yml * Update L2-tests.yml --------- Co-authored-by: nhanasi <navihansi@gmail.com>

RDKEMW-20790 : Improve L2 Coverage for tr69hostif (#507)

d7f0f9e

Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>

tr69hostif 1.4.9 release changelog updates

ea476f9

Merge branch 'release/1.4.9'

7624faf

Merge tag '1.4.9' into develop

34bc947

Tr69hostif release for Develop OTEL feature

Copilot AI review requested due to automatic review settings July 23, 2026 13:11

santoshcomcast requested a review from a team as a code owner July 23, 2026 13:11

Copilot started reviewing on behalf of santoshcomcast July 23, 2026 13:11 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

santoshcomcast merged commit 7048648 into feature/RDKEMW-19163-thunder-migration Jul 29, 2026
15 of 18 checks passed

github-actions Bot locked and limited conversation to collaborators Jul 29, 2026

Navigation Menu

Uh oh!

sync to develop - #516

sync to develop#516
santoshcomcast merged 7 commits into
feature/RDKEMW-19163-thunder-migrationfrom
develop

santoshcomcast commented Jul 23, 2026

Uh oh!

github-advanced-security AI commented Jul 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

santoshcomcast commented Jul 23, 2026

Uh oh!

github-advanced-security AI commented Jul 23, 2026

What Enabling Code Scanning Means:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants