RDKEMW-10029: Remove duplicate RedRecovery parameter - #501
Open
Ananth916 wants to merge 2 commits into
Open
Conversation
Signed-off-by: AnanthaC <anantha_chelladurai@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TR-181 data model XML definitions under waldb/ to remove a duplicated RFC parameter/object definition and to consolidate/move TelemetryEndpoint modeling into the primary generic data-model file used by the merge flow.
Changes:
- Removed the
Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.RedRecovery.object (and itsStatusparameter) fromwaldb/data-model-generic.xml. - Removed
TelemetryEndpoint.RedTmURLfromwaldb/data-model-generic.xmland addedTelemetryEndpoint.RedTmURLintowaldb/data-model/data-model-generic.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/hostif/parodusClient/waldb/data-model/data-model-generic.xml |
Adds TelemetryEndpoint.RedTmURL to the primary generic model used by merge scripts/runtime. |
src/hostif/parodusClient/waldb/data-model-generic.xml |
Removes RedRecovery.Status and removes TelemetryEndpoint.RedTmURL from the legacy/alternate generic XML. |
Comment on lines
88
to
93
| <default type="factory" value="false"/> | ||
| </syntax> | ||
| </parameter> | ||
| </object> | ||
| <object base="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.RedRecovery." access="readOnly" minEntries="1" maxEntries="1" > | ||
| <parameter base="Status" access="readWrite" notification="0" maxNotification="2" > | ||
| <syntax> | ||
| <string/> | ||
| <default type="factory" value="DISABLED"/> | ||
| </syntax> | ||
| </parameter> | ||
| </object> | ||
| <object base="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.WarehouseHost." access="readOnly" minEntries="1" maxEntries="1" > | ||
| <parameter base="CName1" access="readWrite" notification="0" maxNotification="2" > |
Comment on lines
+4172
to
+4178
| <object base="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.TelemetryEndpoint." access="readOnly" minEntries="1" maxEntries="1" > | ||
| <parameter base="RedTmURL" access="readWrite" notification="0" maxNotification="2" > | ||
| <syntax> | ||
| <string/> | ||
| </syntax> | ||
| </parameter> | ||
| </object> |
Code Coverage Summary |
Signed-off-by: AnanthaC <anantha_chelladurai@comcast.com>
Code Coverage Summary |
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.